Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce like types for hovers #881

Closed
TwitchBronBron opened this issue Sep 2, 2023 · 2 comments
Closed

Reduce like types for hovers #881

TwitchBronBron opened this issue Sep 2, 2023 · 2 comments
Milestone

Comments

@TwitchBronBron
Copy link
Member

When hovering over arrays in v0.66.0 branch, we should reduce types that are the same.

image

I'd expect that to be Array<integer> (one integer not three)

@markwpearce
Copy link
Collaborator

Should use this.defaultType instead of innerTypes.map(…)

markwpearce added a commit that referenced this issue Sep 6, 2023
TwitchBronBron added a commit that referenced this issue Sep 13, 2023
* Adds non-statement expressions to AST

* WIP to verify namespace symbol table changes

* Fix broken semantic tokens test

* Solving more tests

* Refactored Symbol Tables to keep track of teh defining AST node of a symbol

* Completes refactor of completions to use symbol tables

* Fixes namespace hovers

* Cache data after loop in BuiltInInterfaceAdder

* Comment documentaation gets a little formatting help - jsdoc tags are respected

* Revert caching of symbol add calls in BuiltInInterfaceAdder

* removed parser in body hack

* fix for #881

* Use leadingTrivia for comments and fix #883

* Solves #882

---------

Co-authored-by: Bronley Plumb <bronley@gmail.com>
@markwpearce
Copy link
Collaborator

Solved 69d3037

markwpearce added a commit that referenced this issue Sep 19, 2023
…) to Type System (#891)

* Adds non-statement expressions to AST

* WIP to verify namespace symbol table changes

* Fix broken semantic tokens test

* Solving more tests

* Refactored Symbol Tables to keep track of teh defining AST node of a symbol

* Completes refactor of completions to use symbol tables

* Fixes namespace hovers

* Cache data after loop in BuiltInInterfaceAdder

* Comment documentaation gets a little formatting help - jsdoc tags are respected

* Revert caching of symbol add calls in BuiltInInterfaceAdder

* removed parser in body hack

* fix for #881

* Use leadingTrivia for comments and fix #883

* Solves #882

* Brightscript Components, interfaces,Events and SceneGraph Nodes are in global SymbolTable

* Fixed enum member issue

* fixed build issue

* Adds built in SceneGraph nodes and Custom components as types

* Fixes some completions issues with custom components

* Adds Custom Components to symbol tables

* Some small fixes

* added test and fixed build error

* fix broken test

* Removed mergedSymbolTable as sibling to scope.symbolTable

* Renamed addDeferredComponentTypeSymbolCreation and generalized type chain seperators

* Added comment for program.componentSymbolsToUpdate

* Update timeout on long running test

* Fixed typo

---------

Co-authored-by: Bronley Plumb <bronley@gmail.com>
@TwitchBronBron TwitchBronBron added this to the v1.0.0 milestone Jan 24, 2024
@TwitchBronBron TwitchBronBron removed the v1 label Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants