Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ORM adapter refactoring #47

Closed
EppO opened this issue Apr 3, 2012 · 0 comments
Closed

ORM adapter refactoring #47

EppO opened this issue Apr 3, 2012 · 0 comments
Labels
feature requests
Milestone
rolify 3.1

Comments

@EppO
Copy link
Member

EppO commented Apr 3, 2012

along issue #32, ORM adapter code needs some cleanup. find and where methods have basically the same purpose but do it differently.
methods for role queries and resource queries could be split up too: less included methods will make the including class lighter.
common methods in both role and resource could be factored in a module, but I don't have any so far.
@ghost ghost assigned EppO Apr 3, 2012
EppO added a commit that referenced this issue Apr 3, 2012
@EppO
get rid of find method in adapter, same purpose than where method, bu…
f5dbaf1 
…t the latter doesn't do n queries per role check

refs #47
closes #32
EppO added a commit that referenced this issue Apr 4, 2012
@EppO
redesign adapters code
565a39a 
don't like the load method in rolify.rb though
maybe a adapter Factory would be a better option
keep investigating
refs #47

change the use_defaults method to use configure block instead of class variables directly. much cleaner
renamed c variable with a more meaningful config variable in the configure block in the initializer (backward compatible)
EppO added a commit that referenced this issue Apr 4, 2012
@EppO
added a Factory to create the adapter in Adapter::Base class
8f80f87 
still need the load method but better placed in the Factory code instead of rolify class methods
refs #47
EppO added a commit that referenced this issue Apr 5, 2012
@EppO
fixed a bug when removing a role using Mongoid adapter
3ce45ac 
changed the adapter code to be able to use the user class
closes #49
refs #47
@EppO EppO closed this as completed Apr 7, 2012
@EppO EppO removed their assignment Jul 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature requests
Projects
None yet
Milestone
rolify 3.1
Development

No branches or pull requests
1 participant
@EppO