Add validation on Role#resource_type #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this will avoid add a permission to a model that don't call the `resourcify`. Now every model that call `resourcify` has his name saved and can be found on the `Rolify.resource_types`. Since the Role model is generated by the generator it is possible to remove this validation.
|
Thanks for the PR! Looks all good. Merging into master now. 👍 |
wldcordeiro
added a commit
that referenced
this pull request
Dec 30, 2014
Add validation on Role#resource_type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this will avoid add a permission to a model that don't call the
resourcify.Now every model that call
resourcifyhas his name saved and can befound on the
Rolify.resource_types.Since the Role model is generated by the generator it is possible to
remove this validation.