Fix regression in generator around belongs_to options compatibility #393
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #392
As mentioned by @NerdDiffer in a417a42#commitcomment-16775070 usage of
:optional => true
introduces an ArgumentError in Rails < 5.This was not caught in our specs, because the generator specs do not actually execute the generated files. While I intend to improve the generator specs to handle such errors in a future PR, this one attends to the regression at hand.