Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression in generator around belongs_to options compatibility #393

Merged
merged 1 commit into from
Apr 18, 2016
Merged

Conversation

lorefnon
Copy link
Contributor

Fixes #392

As mentioned by @NerdDiffer in a417a42#commitcomment-16775070 usage of :optional => true introduces an ArgumentError in Rails < 5.

This was not caught in our specs, because the generator specs do not actually execute the generated files. While I intend to improve the generator specs to handle such errors in a future PR, this one attends to the regression at hand.

@wldcordeiro
Copy link
Member

Thanks for this @lorefnon I'll be merging this and cutting a 5.1.1 tomorrow. Ping me if you're interested in joining the contributors and I'll add you to the community.

@coveralls
Copy link

Coverage Status

Coverage increased (+8.8%) to 92.094% when pulling c5642cc on lorefnon:bugfix/392 into 2a61bcb on RolifyCommunity:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+8.8%) to 92.094% when pulling c5642cc on lorefnon:bugfix/392 into 2a61bcb on RolifyCommunity:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+10.3%) to 93.552% when pulling 731b222 on lorefnon:bugfix/392 into 2a61bcb on RolifyCommunity:master.

@lorefnon
Copy link
Contributor Author

@wldcordeiro I will be happy to join the community. Though I see the library as fairly feature complete as it is, I would continue to help with feature requests, enhancements and regressions as and when time permits.

@lorefnon
Copy link
Contributor Author

@wldcordeiro I believe we should get another release out as multiple people have faced this issue.

While I can merge the PR I don't think I can publish an update to Rubygems.

@wldcordeiro wldcordeiro merged commit 9c29202 into RolifyCommunity:master Apr 18, 2016
@wldcordeiro
Copy link
Member

@lorefnon register for rubygems and email me or ping me here and I can update you as an owner there too

@lorefnon
Copy link
Contributor Author

@wldcordeiro Thanks for merging the PR.

My rubygems account is registered using the same email as the one on the github public profile: lorefnon@gmail.com

@wldcordeiro
Copy link
Member

@lorefnon ownership was added. You should be able to publish new versions. Ping me if you have any questions. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants