Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix migration generator for AR 5.x #463

Merged
merged 3 commits into from
Nov 20, 2017
Merged

fix migration generator for AR 5.x #463

merged 3 commits into from
Nov 20, 2017

Conversation

kirillseva
Copy link
Contributor

@kirillseva kirillseva commented Sep 21, 2017 •
edited
Loading

fix for

❯ rake db:migrate
rake aborted!
StandardError: An error has occurred, this and all later migrations canceled:

Directly inheriting from ActiveRecord::Migration is not supported. Please specify the Rails release the migration was written for:

  class RolifyCreateRoles < ActiveRecord::Migration[4.2]

@kirillseva kirillseva mentioned this pull request Sep 21, 2017
Closed
@coveralls
Copy link

coveralls commented Sep 21, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 93.089% when pulling 2042075 on kirillseva:rolify_migrations_for_rails5 into 3b85e92 on RolifyCommunity:master.

@laertispappas laertispappas mentioned this pull request Oct 7, 2017
Closed
@kthibodeaux kthibodeaux mentioned this pull request Oct 20, 2017
Closed
@coveralls
Copy link

coveralls commented Nov 18, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 93.089% when pulling df74d1c on kirillseva:rolify_migrations_for_rails5 into 9756943 on RolifyCommunity:master.

@coveralls
Copy link

coveralls commented Nov 18, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 93.089% when pulling 910fdc4 on kirillseva:rolify_migrations_for_rails5 into 8377e70 on RolifyCommunity:master.

EppO
EppO approved these changes Nov 20, 2017
View reviewed changes
Copy link
Member

@EppO EppO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for you PR, really appreciated

@EppO EppO merged commit dffb0f6 into RolifyCommunity:master Nov 20, 2017
@kirillseva
Copy link
Contributor Author

@EppO thank you for maintaining rolify

@kirillseva kirillseva deleted the rolify_migrations_for_rails5 branch November 28, 2017 16:49
@cj cj mentioned this pull request Mar 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EppO EppO EppO approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kirillseva @coveralls @EppO