-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-357 Add priority api, strict mode, event api and @DefaultExecute. Snapshot 3.6.0-SNAPSHOT #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rollczi
changed the title
GH-357 Add priority API. Base executors sorting on priority.
GH-357 Add priority API. Base executor execution on priority sorting
Jan 23, 2024
# Conflicts: # litecommands-core/src/dev/rollczi/litecommands/command/executor/CommandExecuteService.java
# Conflicts: # litecommands-core/src/dev/rollczi/litecommands/command/executor/CommandExecuteService.java # litecommands-core/src/dev/rollczi/litecommands/meta/Meta.java # litecommands-framework/src/dev/rollczi/litecommands/LiteCommandsBaseBuilder.java # litecommands-framework/src/dev/rollczi/litecommands/LiteCommandsBuilder.java
…tion. Fix cooldown controller.
…ultController. Add IGNORE_TOO_MANY_ARGUMENTS to Meta.
…ervice. Add unit tests for @ExecuteDefault. Add unit tests for strict mode feature.
Rollczi
changed the title
GH-357 Add priority API. Base executor execution on priority sorting
GH-357 Add priority api, strict mode, event api and @DefaultExecute.
Sep 15, 2024
Rollczi
changed the title
GH-357 Add priority api, strict mode, event api and @DefaultExecute.
GH-357 Add priority api, strict mode, event api and @DefaultExecute. Snapshot 3.6.0-SNAPSHOT
Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WiP
Resolve: #357
Resolve: #220
Resolve: #428
🟢 Add an option to disable strict mode.
If you disable strict mode for a command, then users will be able to add unexpected arguments e.g.
/help first asdfioaosdf asodfn asodimf
<- this will work!You can also disable strict mode by calling:
on builder.
@ExecuteDefault
@Priority
Available events:
Simple example, how to block the execution of a command: