fix: changes need to be detected for un-merged pull requests #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@rollingversions/server (3.0.3 → 3.0.4)Bug Fixes
Packages With No ChangesThe following packages have no user facing changes, so won't be released:
|
ForbesLindesay
force-pushed
the
fix/pr-canary-releases
branch
from
630fa6b
to
6cdebbc
Compare
Un-merged pull requests have 2 commits that should pick up the change log, identified by the "pull/:pr_number/head" and "pull/:pr_number/merge" refs. This PR will add 2 new fields to the refs table to index the pr_number and ref kind ("merge" or "head"). It then updates the `getUnreleasedChanges` function to include pull requests that are indirectly referenced via this ref. I may need to add some indexes to the database to keep this query reasonably efficient.
ForbesLindesay
force-pushed
the
fix/pr-canary-releases
branch
from
6cdebbc
to
02e9f0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Un-merged pull requests have 2 commits that should pick up the change log, identified by the "pull/:pr_number/head" and "pull/:pr_number/merge" refs. This PR will add 2 new fields to the refs table to index the pr_number and ref kind ("merge" or "head"). It then updates the
getUnreleasedChangesfunction to include pull requests that are indirectly referenced via this ref. I may need to add some indexes to the database to keep this query reasonably efficient.