Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about multiple filters #38

Closed
raniesantos opened this issue Dec 3, 2020 · 2 comments
Closed

Question about multiple filters #38

raniesantos opened this issue Dec 3, 2020 · 2 comments
Labels
duplicate This issue or pull request already exists

Comments

@raniesantos
Copy link

If I have a regex filter and a moderator filter, will the moderator messages still show up even if their message doesn't match the regex???

Are the filters treated with an AND logic (fulill all conditions) or an OR logic (fulfill at least one condition)??

@RomainLK
Copy link
Owner

RomainLK commented Dec 3, 2020

For now they are all treated with OR logic. Ticket #14 aims at addressing this problem. I have some thought on how I will be able to include the feature but I have some ground work to do before which leads to version 2.0, mainly #33 #17 #16

@RomainLK RomainLK added the duplicate This issue or pull request already exists label Dec 3, 2020
@raniesantos
Copy link
Author

raniesantos commented Dec 3, 2020

Thanks for the reply. I actually prefer the OR logic.

My regex matches messages that contain at least 2 english letters [A-Za-z]{2,} to reduce the visual clutter of Japanese chat messages.

However I'm not able to test easily if I would still be able to see moderator/owner messages even if it is all in Japanese, so I just asked directly here.

@RomainLK RomainLK closed this as completed Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants