Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing feed default #69

Open
RomainLK opened this issue Jan 23, 2021 · 2 comments
Open

Missing feed default #69

RomainLK opened this issue Jan 23, 2021 · 2 comments

Comments

@RomainLK
Copy link
Owner

Ah, I see. Console shows this

 popout-main.js:7 TypeError: Cannot read property 'default' of undefined
     at channelArchive (popout-main.js:21)
     at r.forEachGetter.t._wrappedGetters.(chrome-extension://mnldnbhgfocmkehnlkeanlhfmopepnko/anonymous function) (chrome-extension://mnldnbhgfocmkehnlkeanlhfmopepnko/popout-main.js:15:111736)
     at Pn.<anonymous> (popout-main.js:15)
     at hn.get (popout-main.js:7)
     at hn.evaluate (popout-main.js:7)
     at Pn.channelArchive (popout-main.js:7)
     at Object.get [as channelArchive] (popout-main.js:15)
     at a.<anonymous> (popout-main.js:38)
     at a.t._render (popout-main.js:7)
     at a.r (popout-main.js:7)

Here's a link to what the debug command spit out https://litter.catbox.moe/5xpvjh.txt

Originally posted by @DDDespair in #61 (comment)

Fix will be seeing how the videos settings weren't properly initialized for and prevent it https://www.youtube.com/watch?v=5P9skO8lBzE
And also make it so the interface doesn't crash if it does happen.

@DDDespair
Copy link

DDDespair commented Jan 24, 2021

Went ahead with the re-install and for whatever reason it seems to be working properly now. I ended up making my own filters instead of using the default presets however, so that may be it. I needed Owner, Moderator and Translation for Global, but only Owner and Translation for a specific channel, and there was some issue with getting those set properly. It's probably because of how I went about it. I had set the Translation as Global and added Owner and Moderator to it, then applied it while on one channel. I then moved to the other channel I needed specific filters for, tried making a custom for Owner and Translation and applying it to the channel, but it for some reason it ended up being applied to the the channel I was no longer on, the previous channel I had set the Global filter to. Anyway, I did the reset under settings and did customs instead of loading defaults and now it seems to be working fine. (haven't caught sight of an owner message yet to test it but everything else works as it should so I assume it won't be a problem)

Anyway, thanks for the help. Hopefully the log helps you pin down the bug.

@RomainLK
Copy link
Owner Author

RomainLK commented Jan 26, 2021

Thanks for the huge step by step. For now I have pushed a beta here on Github for 2.1.4. It will prevent the popout from breaking if you have the same problem as last time. Going from your scenario here, I added some safety which prevents filters from leaking between current video and presets.

I have found some minor issue if someone tries to configure a preset between multiple popout but for now I let it go because it shouldn't break anything and easily avoided... Fix for another release.

Ticket will remain open till official release of 2.1.4

edit: beta link https://github.com/RomainLK/ytc-filter/releases/tag/v2.1.4-beta.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants