Override Argument

[sschmocker]

I cant seem to get it to work, am I doing something wrong?
powershell.exe -Executionpolicy Bypass -File winget-install.ps1 -AppIDs "Citrix.Workspace --override "/silent /noreboot /includeSSON /forceinstall""

[Romanitho]

This is due to your quote. Try to escape
What you coud try as well:
powershell.exe -Executionpolicy Bypass -Command .\winget-install.ps1 -AppIDs 'Citrix.Workspace --override "/silent /noreboot /includeSSON /forceinstall"'

[sschmocker]

This is due to your quote. Try to escape What you coud try as well: powershell.exe -Executionpolicy Bypass -Command .\winget-install.ps1 -AppIDs 'Citrix.Workspace --override "/silent /noreboot /includeSSON /forceinstall"'

I tried that, but that also Fails.

[Romanitho]

try escape the quote with \ like this :
powershell.exe -Executionpolicy Bypass -File winget-install.ps1 -AppIDs "Citrix.Workspace --override \"/silent /noreboot /includeSSON /forceinstall\""

[Romanitho]

@KnifMelti nice example here to troubleshoot

[KnifMelti]

No problem installing 7-Zip (7zip.7zip) with Start-Process -Wait:
powershell.exe -Executionpolicy Bypass -File winget-install.ps1 -AppIDs 7zip.7zip

winget-install.ps1 continues as it should...

[KnifMelti]

Solution: Get-Process winget -ErrorAction SilentlyContinue | Foreach-Object { $_.WaitForExit() }

#Install App
Write-Log "Installing $AppID..." "Yellow"
$Command = "install --id $AppID --silent --accept-package-agreements --accept-source-agreements $AppArgs"
Start-Process -FilePath "$winget" -ArgumentList "$Command" -NoNewWindow
Get-Process winget -ErrorAction SilentlyContinue | Foreach-Object { $_.WaitForExit() }

#Uninstall App
Write-Log "Uninstalling $AppID..." "Yellow"
$Command = "uninstall --id $AppID --silent --accept-source-agreements $AppArgs"
Start-Process -FilePath "$winget" -ArgumentList "$Command" -NoNewWindow
Get-Process winget -ErrorAction SilentlyContinue | Foreach-Object { $_.WaitForExit() }

[Romanitho]

Weird that -wait doesn't not work as expected

[KnifMelti]

Yes, but when reading on https://docs.microsoft.com/en-us/powershell/module/microsoft.powershell.management/start-process?view=powershell-7.2
It states:
"-Wait
Indicates that this cmdlet waits for the specified process and its descendants to complete before accepting more input. This parameter suppresses the command prompt or retains the window until the processes finish."

I reckon that some process is started in the installation that never ends (or something)...

[Romanitho]

I see. Your workaround seems good anyway ;)

[KnifMelti]

#21

[KnifMelti]

@sschmocker did our answers help you anything?
Release 1.4.1 has the Start-Process/Get-Process implementation and Citrix Workspace can be installed with:
powershell.exe -Executionpolicy Bypass -File winget-install.ps1 -AppIDs "Citrix.Workspace --override \"/silent /noreboot /includeSSON /forceinstall\""

@Romanitho the $AppArgs should be removed from winget-install.ps1 when uninstalling (but maybe --override gets implemented in the future?).

And, as a security measure:
If you're running this in system context, you should start powershell/winget-install.ps1 with -Windowstyle hidden!
Otherwise the user can run a browser via the powershell window properties (Microsoft provides the links...) and in the context of System do anything on the client!

[Romanitho]

I agree, we could remove it for the uninstall command. And if MS implement the feature, it will be easy to put it back again.

Regarding system context, as a user you shouldn't see the powershell window (this is why you should not see the powershell run by the scheduled task)

[Romanitho]

And if you run in user context with windowstyle hidden, you might observe a flash PowerShell window (quickly hide after run). To avoid this, we use the little vbs script for the notification script for example (WAU).

[KnifMelti]

@Romanitho Your absolutely right about system context! My brain was fried in the morning ;)