Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifications working... #10

Merged
merged 3 commits into from
Apr 9, 2022
Merged

Modifications working... #10

merged 3 commits into from
Apr 9, 2022

Conversation

KnifMelti
Copy link
Contributor

...and FileZilla as an example.

@Romanitho
Copy link
Owner

Hi,
thanks for your contributions :)
In my point of view, you can put your mod directly inside the script if you want to use it with SCCM or Intune, as your might package one script per app.
Except if you want to use it for bulk, with mod for several apps at once ?

@KnifMelti
Copy link
Contributor Author

KnifMelti commented Apr 9, 2022

Yes, I could, but I won't :)
Because; were using this as a Framework for winget installations in SCCM (as Available applications under Software Center for the user to Install/Uninstall on their own).
Directory structure for the source:
mods
GetKing.cmd (powershell.exe -Windowstyle hidden -ExecutionPolicy bypass -File "%~dp0winget-install.ps1" %*)
winget-install.ps1

In this way we only have to create an application in SCCM (for every application we've tested and approved, because there's so many flaws with the winget repo applications which often leads to the users getting a chance to do things in the context of the running process as System) and as Installation/Uninstallation use:

  • Installation program: GetKing.cmd -AppIDs TimKosse.FileZilla.Client -WAUWhiteList
  • Uninstall program: GetKing.cmd -AppIDs TimKosse.FileZilla.Client -WAUWhiteList -Uninstall

In this way, we can just code a snippet, place it under "mods" and it automatically executes via your installation/uninstallation in winget-install.ps1.
Furthermore, if and when you implement the Modification structure in WAU we can then implement a filecopy/-delete of the mods from the SCCM cache to/from the "mods" directory under "C:\ProgramData\Winget-AutoUpdate"
When WAU updates these white listed applications there also need to be mods for the ones we've fixed in the installation...

So, in my mind, this is the ultimate way :)

@KnifMelti
Copy link
Contributor Author

KnifMelti commented Apr 9, 2022

...and never touch the winget-install.ps1 again (error safe) ;) and as you mentioned if we wrap several winget installations together...

@Romanitho
Copy link
Owner

ok, got it. It might be useful indeed.
Regarding several installs at once, I'm thinking about removing this option, because we need to implement the feature to parse the winget native arguments, and in my mind I wanted to keep this install script as simple as possible :)

@Romanitho Romanitho added the enhancement New feature or request label Apr 9, 2022
@Romanitho Romanitho merged commit 7e4d235 into Romanitho:main Apr 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants