Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor changes on Mod functions #11

Merged
merged 4 commits into from
Apr 9, 2022
Merged

Minor changes on Mod functions #11

merged 4 commits into from
Apr 9, 2022

Conversation

Romanitho
Copy link
Owner

@KnifMelti I made few changes. Do you approve ?

@KnifMelti
Copy link
Contributor

Of course!
Its your code ;)
I was thinking one could call the script with a parameter "-Mods" to trigger the check so it doesn't have to do the filecheck everytime...

@Romanitho
Copy link
Owner Author

And we could even imagine a -premod and a -postmod parameters in case you want to run scripts before and/or after winget install.

@KnifMelti
Copy link
Contributor

I didn't get it working until I used "$Script:ModsInstall...", but I guess you will...

@Romanitho
Copy link
Owner Author

Right, i'll fix it now

@Romanitho
Copy link
Owner Author

should be fixed now :)

@KnifMelti
Copy link
Contributor

Ah, so that's the way ;)

@Romanitho
Copy link
Owner Author

If you confirm that it works, I merge :)

@KnifMelti
Copy link
Contributor

Moment, please!

@KnifMelti
Copy link
Contributor

KnifMelti commented Apr 9, 2022

As intended when the dialog appeared and until I closed it by uninstalling. Also when I didn't ok the uninstallation.
So, its all good :)

18:16:39 - ### 2022-04-09 - NEW UNINSTALL REQUEST ###
18:16:39 - Using following Winget Cmd: C:\Users\knifm\AppData\Local\Microsoft\WindowsApps\winget.exe
18:16:40 - TimKosse.FileZilla.Client exists on Winget Repository.
18:16:42 - Uninstalling TimKosse.FileZilla.Client...
18:16:43 - Modifications for TimKosse.FileZilla.Client during uninstall are being applied...
18:16:49 - TimKosse.FileZilla.Client successfully uninstalled.
18:16:52 - ### END REQUEST ###

@Romanitho Romanitho merged commit c3da0be into main Apr 9, 2022
@Romanitho Romanitho deleted the Mod branch April 9, 2022 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants