Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop Mods checking #70

Merged
merged 15 commits into from
Dec 7, 2022
Merged

Develop Mods checking #70

merged 15 commits into from
Dec 7, 2022

Conversation

KnifMelti
Copy link
Contributor

Starting developing...

@KnifMelti KnifMelti mentioned this pull request Dec 2, 2022
Closed
@KnifMelti KnifMelti marked this pull request as draft December 2, 2022 20:44
@KnifMelti KnifMelti marked this pull request as ready for review December 3, 2022 05:31
@KnifMelti
Copy link
Contributor Author

KnifMelti commented Dec 4, 2022 •
edited
Loading

This PR has one breaking change from the way AppID-install.ps1 was used earlier (just like a9da3dd for uninstall/uninstalled).
Now:

  • AppID-install.ps1 : runs during install (before install check)
  • AppID-installed.ps1 : runs after install has been confirmed

Already existing AppID-install.ps1/AppID-uninstall.ps1 must be tested if they work (they earlier executed after install/uninstall had been confirmed)!

@KnifMelti KnifMelti marked this pull request as draft December 4, 2022 15:25
@KnifMelti KnifMelti marked this pull request as ready for review December 4, 2022 16:37
@KnifMelti KnifMelti marked this pull request as draft December 4, 2022 19:23
@KnifMelti
Copy link
Contributor Author

One final thing...

@KnifMelti KnifMelti marked this pull request as ready for review December 4, 2022 20:38
@KnifMelti
Copy link
Contributor Author

Mods now fully developed 🤯

@KnifMelti
Copy link
Contributor Author

Done 😉

@Romanitho
Copy link
Owner

thanks for that really good feature 👍

@Romanitho Romanitho merged commit 3051bd1 into Romanitho:main Dec 7, 2022
@KnifMelti KnifMelti deleted the Develop branch December 7, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KnifMelti @Romanitho