Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retarget to net6 and Cake.Common 2.2. #50

Closed
wants to merge 2 commits into from

Conversation

sqeezy
Copy link

@sqeezy sqeezy commented Jul 25, 2022

There were no apparent problems with this update.

@sqeezy
Copy link
Author

sqeezy commented Jul 25, 2022

Fixes #47

@sqeezy
Copy link
Author

sqeezy commented Jul 25, 2022

I would also be willing to co-maintain this repo in the future if that helps.

@taconaut
Copy link

Now that cake 3.0 removed the DotNetCore aliases, this change has become required as Cake.Coverlet can't be used with Cake 3.0 anymore. See cake-build/cake#4072
@Romanx would you integrate the changes if we make a PR to migrate to Cake 3.0 or do we have to clone this repo and push a new nuget? I guess you're the owner of the package; I've never pushed to nuget.org but think we'd have to give the package a new name.

@sqeezy
Copy link
Author

sqeezy commented Nov 16, 2022

I would very much like to stay inside this project. Maintaing a fork seems like a bad idea in this case.
I can only repeat that me and my company would be happy to support this project and I personally would offer to co-maintain if wanted.

@Romanx
Copy link
Owner

Romanx commented Nov 17, 2022

Hey @sqeezy and @taconaut

Thanks for engaging with this, I started bumping to Cake 2.0.0 awhile back and ended up down the well yak shaving and never found time to get back to this.

I've bumped to the latest version and pushed a new build to nuget, please let me know if you find any issues and i'll try keep on top of this in future.

@Romanx Romanx closed this Nov 17, 2022
@sqeezy sqeezy deleted the cake2.0_update branch November 18, 2022 07:28
@taconaut
Copy link

@Romanx Thanks, works like a charm

@sqeezy
Copy link
Author

sqeezy commented Nov 18, 2022

@Romanx Agreed. Sadly dotnet test is broken under 7.0.100 but having Cake.Coverlet on the newest version of Cake is reassuring. I'd like to reiterate that me and my company would be happy to help with maintaining this package.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants