New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JavaScript event listener #70
Comments
I'll take this one! 😄 |
@RomchyFCC didn't notice you upvoted my comment. I was waiting for someone's approval to start. I'll start working on it ASAP. |
@h1tag you don't need our permission :) and no worries, take your time, I'm excited to see how you make it |
You mean I should work on issue #74 first, then on this one? |
No, not at all, it just means you should work on contributors.js instead of
index.js
…On Tue, Apr 3, 2018, 8:50 AM h1tag ***@***.***> wrote:
@RomchyFCC <https://github.com/RomchyFCC>
EDIT: in the light of recent issues, this issue is still available but it
is meant for the contributors.js.
More info here 74
You mean I should work on issue #74
<#74> first,
then on this one?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#70 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AWIMEzt6UVYwNDOm9qh-t4INyRCpmT_bks5tkxvAgaJpZM4SqQHA>
.
|
@RomchyFCC but there's still no contributors.js file in this repo. So, I have to work on that issue first (I will have to create a contributors.js file ...), right? |
Oh right, yes, in that case create a new file and i think thats it for that
issue so you can do both then
…On Tue, Apr 3, 2018, 11:11 AM h1tag ***@***.***> wrote:
@RomchyFCC <https://github.com/RomchyFCC> but there's still no
contributors.js file in this repo. So, I have to work on that issue first
(I will have to create a contributors.js file ...), right?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#70 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AWIMExOpFcEdbB_QWYcLerbu37B9n-Xmks5tkzy-gaJpZM4SqQHA>
.
|
Thanks to @h1tag for resolving this issue! |
Add an event listener to the sunshine.svg element which would make it disappear again after clicking it.
The sunshine element currently displays when a user click anywhere on the page but it is then stuck there.
use methods like
const img = document.querySelector('img')
ordocument.getElementById('<img id>')
and then add an event listener likeimg.addEventListener('click', function(){ })
I realise this might be a more "advanced" project but feel free to try and do it anyway. You can ask me for more in-depth instructions on gitter @RomchyFCC or here. I'll reply ASAP.
EDIT: in the light of recent issues, this issue is still available but it is meant for the contributors.js.
More info here 74
The text was updated successfully, but these errors were encountered: