Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavaScript event listener #70

Closed
RomchyFCC opened this issue Mar 14, 2018 · 8 comments
Closed

JavaScript event listener #70

RomchyFCC opened this issue Mar 14, 2018 · 8 comments
Labels
enhancement New feature or request up-for-grabs

Comments

@RomchyFCC
Copy link
Owner

RomchyFCC commented Mar 14, 2018

Add an event listener to the sunshine.svg element which would make it disappear again after clicking it.

The sunshine element currently displays when a user click anywhere on the page but it is then stuck there.
use methods like const img = document.querySelector('img') or document.getElementById('<img id>') and then add an event listener like img.addEventListener('click', function(){ })

I realise this might be a more "advanced" project but feel free to try and do it anyway. You can ask me for more in-depth instructions on gitter @RomchyFCC or here. I'll reply ASAP.

EDIT: in the light of recent issues, this issue is still available but it is meant for the contributors.js.
More info here 74

@RomchyFCC RomchyFCC added enhancement New feature or request up-for-grabs labels Mar 14, 2018
@h1tag
Copy link
Contributor

h1tag commented Mar 20, 2018

I'll take this one! 😄

@h1tag
Copy link
Contributor

h1tag commented Apr 2, 2018

@RomchyFCC didn't notice you upvoted my comment. I was waiting for someone's approval to start. I'll start working on it ASAP.

@RomchyFCC
Copy link
Owner Author

@h1tag you don't need our permission :) and no worries, take your time, I'm excited to see how you make it

@h1tag
Copy link
Contributor

h1tag commented Apr 3, 2018

@RomchyFCC

EDIT: in the light of recent issues, this issue is still available but it is meant for the contributors.js.
More info here 74

You mean I should work on issue #74 first, then on this one?

@RomchyFCC
Copy link
Owner Author

RomchyFCC commented Apr 3, 2018 via email

@h1tag
Copy link
Contributor

h1tag commented Apr 3, 2018

@RomchyFCC but there's still no contributors.js file in this repo. So, I have to work on that issue first (I will have to create a contributors.js file ...), right?

@RomchyFCC
Copy link
Owner Author

RomchyFCC commented Apr 3, 2018 via email

@RomchyFCC
Copy link
Owner Author

Thanks to @h1tag for resolving this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request up-for-grabs
Projects
None yet
Development

No branches or pull requests

2 participants