Improve Sciebo downloads #117
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
septatrix
requested changes
Jun 12, 2024
| @@ -24,6 +24,7 @@ install_requires = | |||
| yt-dlp>=2021.12.27 | |||
| pdfkit>=0.6.0 | |||
| tqdm>=4.0.0 | |||
| lxml>=5.0.0 | |||
There was a problem hiding this comment.
What is lxml needed for? (I know it can be used by bs4 but I do not know why it is necessary)
There was a problem hiding this comment.
Well the response of /public.php/webdav is a xml-file which describes the structure of the sharing link we found.
To be able to parse xml we need to install lxml so that bs4 can use it.
There was a problem hiding this comment.
As that XML is highly structured it should be sufficient to take the XML parser from the stdlib
Comment on lines
+1053
to
+1054
| sciebo_links = list( | ||
| set(re.findall("https://rwth-aachen.sciebo.de/s/[a-zA-Z0-9-]+", text)) |
There was a problem hiding this comment.
Just move the set() to the for-loop and drop the list, it has no effect
Co-authored-by: Nils K <24257556+septatrix@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves #110