Cannot read property 'rnfbEncode' of undefined, js engine: hermes #321

mMarcos208 · 2023-12-05T18:56:16Z

My code

import {Platform} from 'react-native'
import ReactNativeBlobUtil, {ReactNativeBlobUtilConfig} from 'react-native-blob-util'


export const options = (name: string, extension = 'pdf', notification = true) => {
  const {fs} = ReactNativeBlobUtil
  const {
    dirs: {DocumentDir, DownloadDir},
  } = fs
  return Platform.select({
    ios: {
      fileCache: true,
      path: `${DocumentDir}/${name}`,
      title: name,
    },
    android: {
      fileCache: true,
      addAndroidDownloads: {
        useDownloadManager: true,
        notification,
        title: name,
        path: `${DownloadDir}/${name}.${extension}`,
      },
    },
  }) as ReactNativeBlobUtilConfig
}

import {useCallback, useState} from 'react'
import {Platform} from 'react-native'
import ReactNativeBlobUtil from 'react-native-blob-util'

import {options} from '@/utils/blob'
import {filesPermission} from '@/utils/hardwarePermissions'

export const useFetchBlob = () => {
  const [progress, setProgress] = useState<number>()

  const fetchBlob = useCallback(
    async (
      url: string,
      name: string,
      extension?: string,
      headers?: {
        [key: string]: string
      },
    ) => {
      try {
        const hasDownloadPermission = await filesPermission()
        if (hasDownloadPermission) {
          const {config} = ReactNativeBlobUtil

          const res = await config(options(name, extension))
            .fetch('GET', url, headers)
            .progress((received, total) => {
              setProgress(received / total)
            })

          if (Platform.OS === 'ios') {
            ReactNativeBlobUtil.ios.previewDocument(res.path())
          }
        } else {
        }
      } catch (error) {} finally {
        setProgress(undefined)
      }
    },
    [progress],
  )

  return {
    progress,
    fetchBlob,
  }
}

"react-native": "0.72.7"
"react-native-blob-util": "^0.19.6",

The text was updated successfully, but these errors were encountered:

Mohamed-Sheik-Ali · 2023-12-06T05:15:57Z

Hi @mMarcos208 I think the issue is with package version, I also stumbled on the same error. So, I downgraded the version to react-native-blob-util@0.19.4 it works for me. Hope it helps.

RemiHin · 2023-12-08T10:21:15Z

Hi @mMarcos208 I think the issue is with package version, I also stumbled on the same error. So, I downgraded the version to react-native-blob-util@0.19.4 it works for me. Hope it helps.

I have the same issue, reverting back to 0.19.4 solved it for now

appa-gomi · 2023-12-13T01:19:30Z

Comment the two line(273, 274) in fetch.js

                         fs.session(options.session).add(data);
                 }
                 respInfo.rnfbEncode = rawType;
-                if ('uninit' in respInfo && respInfo.uninit) // event didn't fire yet so we override it here
-                    respInfo = responseInfo;
+                // if ('uninit' in respInfo && respInfo.uninit) // event didn't fire yet so we override it here
+                //     respInfo = responseInfo;
                 resolve(new FetchBlobResponse(taskId, respInfo, data));
             }

zehratok · 2023-12-22T13:48:41Z

Comment the two line(273, 274) in fetch.js

                         fs.session(options.session).add(data);
                 }
                 respInfo.rnfbEncode = rawType;
-                if ('uninit' in respInfo && respInfo.uninit) // event didn't fire yet so we override it here
-                    respInfo = responseInfo;
+                // if ('uninit' in respInfo && respInfo.uninit) // event didn't fire yet so we override it here
+                //     respInfo = responseInfo;
                 resolve(new FetchBlobResponse(taskId, respInfo, data));
             }

This method worked for me, thank you. However, I didn't understand why such a change was made in the package; the commit messages were not explanatory.

MohamedMegdich1 · 2023-12-28T11:57:15Z

Hi @mMarcos208, I have fixed this issue by wrapping the path with path: ReactNativeBlobUtil.wrap(filePath)

`
import {Platform} from 'react-native'
import ReactNativeBlobUtil, {ReactNativeBlobUtilConfig} from 'react-native-blob-util'

export const options = (name: string, extension = 'pdf', notification = true) => {
const {fs} = ReactNativeBlobUtil
const {
dirs: {DocumentDir, DownloadDir},
} = fs
return Platform.select({
ios: {
fileCache: true,
path: ReactNativeBlobUtil.wrap(${DocumentDir}/${name}),
title: name,
},
android: {
fileCache: true,
addAndroidDownloads: {
useDownloadManager: true,
notification,
title: name,
path: ReactNativeBlobUtil.wrap( ${DownloadDir}/${name}.${extension}),
},
},
}) as ReactNativeBlobUtilConfig
}
`

imanshul · 2024-01-30T13:13:27Z

Any update? still facing this issue, and downgrading to 0.19.4 also doesn't resolve the issue

TheWirv · 2024-02-09T09:30:04Z

Comment the two line(273, 274) in fetch.js

                         fs.session(options.session).add(data);
                 }
                 respInfo.rnfbEncode = rawType;
-                if ('uninit' in respInfo && respInfo.uninit) // event didn't fire yet so we override it here
-                    respInfo = responseInfo;
+                // if ('uninit' in respInfo && respInfo.uninit) // event didn't fire yet so we override it here
+                //     respInfo = responseInfo;
                 resolve(new FetchBlobResponse(taskId, respInfo, data));
             }

This patch also fixed the issue for me, thanks!

obinote · 2024-02-13T02:27:39Z

diff --git a/node_modules/react-native-blob-util/fetch.js b/node_modules/react-native-blob-util/fetch.js
index ed4e67f..fe541e5 100644
--- a/node_modules/react-native-blob-util/fetch.js
+++ b/node_modules/react-native-blob-util/fetch.js
@@ -270,8 +270,8 @@ export function fetch(...args: any): Promise {
                         fs.session(options.session).add(data);
                 }
                 respInfo.rnfbEncode = rawType;
-                if ('uninit' in respInfo && respInfo.uninit) // event didn't fire yet so we override it here
-                    respInfo = responseInfo;
+                // if ('uninit' in respInfo && respInfo.uninit) // event didn't fire yet so we override it here
+                //     respInfo = responseInfo;
                 resolve(new FetchBlobResponse(taskId, respInfo, data));
             }

It work for me.

Sakib-203-15-3883 · 2024-02-13T10:55:01Z

Hi @mMarcos208 I think the issue is with package version, I also stumbled on the same error. So, I downgraded the version to react-native-blob-util@0.19.4 it works for me. Hope it helps.

It works for me.

RonRadtke · 2024-02-13T20:06:24Z

Can you tell me in which line this fails exactly?
Does it happen on Android or iOS or both?
Would like to fix this.

But to explain the changes.
There are cases where the native events are triggered after the callback is triggered. Therefor the callback gets all information and if the event happens to arrive after the callback we still can resolve with all required information.

Just that seems like I missed something

maksimko · 2024-02-14T17:34:40Z

In my case it only happens on Android. The same code on iOS works fine.
Version 0.19.4 works well on both platforms.

raymondjacobson · 2024-02-16T03:20:35Z

+1 seeing this issue. 0.19.4 fixes it for me as well.

endrits079 · 2024-02-16T13:51:19Z

Hi @mMarcos208, I have fixed this issue by wrapping the path with path: ReactNativeBlobUtil.wrap(filePath)

` import {Platform} from 'react-native' import ReactNativeBlobUtil, {ReactNativeBlobUtilConfig} from 'react-native-blob-util'

export const options = (name: string, extension = 'pdf', notification = true) => { const {fs} = ReactNativeBlobUtil const { dirs: {DocumentDir, DownloadDir}, } = fs return Platform.select({ ios: { fileCache: true, path: ReactNativeBlobUtil.wrap(${DocumentDir}/${name}), title: name, }, android: { fileCache: true, addAndroidDownloads: { useDownloadManager: true, notification, title: name, path: ReactNativeBlobUtil.wrap( ${DownloadDir}/${name}.${extension}), }, }, }) as ReactNativeBlobUtilConfig } `

worked for me

paskalov-aris · 2024-02-20T20:05:29Z

Hi @mMarcos208 I think the issue is with package version, I also stumbled on the same error. So, I downgraded the version to react-native-blob-util@0.19.4 it works for me. Hope it helps.

Downgrading from 0.19.6 to 0.19.4 fixed the error in my case. Thanks.

mMarcos208 · 2024-02-22T13:44:02Z

Downgrade to 0.19.4 cause this error #204

RonRadtke · 2024-02-23T10:56:59Z

@mMarcos208 @paskalov-aris @endrits079
Anyone can tell we whitch line is causing the probelm?
And is it an on progress event or when the request is finished?
Android / ios / both?

Some more information to reproduce it would be great so you don't have to downgrade

bhavdeep-pixer · 2024-02-24T08:31:07Z

Hi @mMarcos208 I think the issue is with package version, I also stumbled on the same error. So, I downgraded the version to react-native-blob-util@0.19.4 it works for me. Hope it helps.

It's also worked for me. Thanks @Mohamed-Sheik-Ali

RonRadtke · 2024-02-24T16:13:34Z

@mMarcos208 @paskalov-aris @endrits079 Anyone can tell we whitch line is causing the probelm? And is it an on progress event or when the request is finished? Android / ios / both?

Some more information to reproduce it would be great so you don't have to downgrade

@bhavdeep-pixer same question to you.

hopefully fixes this issue

herberthk · 2024-03-22T08:11:24Z

Hi @mMarcos208 I think the issue is with package version, I also stumbled on the same error. So, I downgraded the version to react-native-blob-util@0.19.4 it works for me. Hope it helps.

Thanks solved my issue

sadewole · 2024-05-06T10:56:36Z

The file got downloaded but cannot locate it in the device file manager. It was downloaded to the internal app which is not visible.

How can this be fixed, please?

aimane-chnaif mentioned this issue Jan 22, 2024

[HOLD for payment 2024-01-31] [HOLD for payment 2024-01-30] Android - IOU -In distance request, when user download receipt, app crashes. Expensify/App#34883

Closed

6 tasks

dangleh mentioned this issue Jan 29, 2024

Android 14: Error: Download manager download failed, the file does not downloaded to destination. #330

Open

raymondjacobson mentioned this issue Feb 16, 2024

⚠️ [PAY-2493] Replace RNFetchBlob with ReactNativeBlobUtil AudiusProject/audius-protocol#7624

Merged

RonRadtke closed this as completed in 3261740 Feb 26, 2024

RonRadtke pushed a commit that referenced this issue Feb 26, 2024

fixes #321

618685f

hopefully fixes this issue

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cannot read property 'rnfbEncode' of undefined, js engine: hermes #321

Cannot read property 'rnfbEncode' of undefined, js engine: hermes #321

mMarcos208 commented Dec 5, 2023

Mohamed-Sheik-Ali commented Dec 6, 2023

RemiHin commented Dec 8, 2023

appa-gomi commented Dec 13, 2023

zehratok commented Dec 22, 2023

MohamedMegdich1 commented Dec 28, 2023 •

edited

Loading

imanshul commented Jan 30, 2024 •

edited

Loading

TheWirv commented Feb 9, 2024

obinote commented Feb 13, 2024 •

edited

Loading

Sakib-203-15-3883 commented Feb 13, 2024

RonRadtke commented Feb 13, 2024 •

edited

Loading

maksimko commented Feb 14, 2024

raymondjacobson commented Feb 16, 2024

endrits079 commented Feb 16, 2024

paskalov-aris commented Feb 20, 2024

mMarcos208 commented Feb 22, 2024

RonRadtke commented Feb 23, 2024 •

edited

Loading

bhavdeep-pixer commented Feb 24, 2024

RonRadtke commented Feb 24, 2024

herberthk commented Mar 22, 2024

sadewole commented May 6, 2024

Cannot read property 'rnfbEncode' of undefined, js engine: hermes #321

Cannot read property 'rnfbEncode' of undefined, js engine: hermes #321

Comments

mMarcos208 commented Dec 5, 2023

Mohamed-Sheik-Ali commented Dec 6, 2023

RemiHin commented Dec 8, 2023

appa-gomi commented Dec 13, 2023

zehratok commented Dec 22, 2023

MohamedMegdich1 commented Dec 28, 2023 • edited Loading

imanshul commented Jan 30, 2024 • edited Loading

TheWirv commented Feb 9, 2024

obinote commented Feb 13, 2024 • edited Loading

Sakib-203-15-3883 commented Feb 13, 2024

RonRadtke commented Feb 13, 2024 • edited Loading

maksimko commented Feb 14, 2024

raymondjacobson commented Feb 16, 2024

endrits079 commented Feb 16, 2024

paskalov-aris commented Feb 20, 2024

mMarcos208 commented Feb 22, 2024

RonRadtke commented Feb 23, 2024 • edited Loading

bhavdeep-pixer commented Feb 24, 2024

RonRadtke commented Feb 24, 2024

herberthk commented Mar 22, 2024

sadewole commented May 6, 2024

MohamedMegdich1 commented Dec 28, 2023 •

edited

Loading

imanshul commented Jan 30, 2024 •

edited

Loading

obinote commented Feb 13, 2024 •

edited

Loading

RonRadtke commented Feb 13, 2024 •

edited

Loading

RonRadtke commented Feb 23, 2024 •

edited

Loading