Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for RN 0.72.1 #266

Merged
merged 1 commit into from
Jul 22, 2023
Merged

Fix for RN 0.72.1 #266

merged 1 commit into from
Jul 22, 2023

Conversation

billnbell
Copy link

This PR fixes use_framework! for RN 0.72.1.

Please check it out. The path works on my PC - but errors if I don't change it.

@RonRadtke
Copy link
Owner

Could you maybe explain a little why you had to make these changes?
Did you try if the current version works in a new app with the new arch?

@billnbell
Copy link
Author

Yeah the current version does not work when using use_frameworks! :linkage => :static

I get cannot find: <React-Codegen/ReactNativeBlobUtilSpec/ReactNativeBlobUtilSpec.h>

But if I add these changes (which is recommended anyways by React-Native team going forward) with install_modules_dependencies(s) - so that change it good to go.

I am unsure why React-Codegen is not finding the ReactNativeBlobUtilSpec.h file, but this works for me too.

#import <React-Codegen/ReactNativeBlobUtilSpec/ReactNativeBlobUtilSpec.h>
changed to:
#import <ReactNativeBlobUtilSpec/ReactNativeBlobUtilSpec.h>

@billnbell
Copy link
Author

billnbell commented Jul 5, 2023

I would also recommend you switch example app to use use_frameworks! :linkage => :static since most people using New Arch is using that since RN-Firebase requires it now.

@RonRadtke
Copy link
Owner

Does the changes still work without the !use_framework?

@billnbell
Copy link
Author

yes it still works - in RN 72+. Otherwise wrap the install_modules_dependencies(s) with if use_fabric

@RonRadtke
Copy link
Owner

I'll merge it this week and bring it live as 0.19.0.
Just have to go trough the documentation in the reactwg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants