- implemented better error handling and error recovery

RonSijm · Jan 6, 2023 · fedbe4d · fedbe4d
1 parent fbf8a3f
commit fedbe4d
Show file tree

Hide file tree

Showing 5 changed files with 57 additions and 9 deletions.
diff --git a/RonSijm.ButtFish/Ascii/FENToCharArrayConverter.cs b/RonSijm.ButtFish/Ascii/FENToCharArrayConverter.cs
@@ -16,6 +16,11 @@ public static class FENToCharArrayConverter
 
         var piecePositionsArray = ReplaceDigitsWithEmptyStrings(fenLineSplit[0]).Split('/');
 
+        if (piecePositionsArray.Length != 8)
+        {
+            return null;
+        }
+
         for (var index = 0; index < piecePositionsArray.Length; index++)
         {
             var row = piecePositionsArray[index];

diff --git a/RonSijm.ButtFish/Ascii/FENToOutputFacade.cs b/RonSijm.ButtFish/Ascii/FENToOutputFacade.cs
@@ -9,6 +9,12 @@ public static bool PaintBoard(string fenPosition)
         try
         {
             var boardModel = fenPosition.ConvertToCharArray();
+
+            if (boardModel == null)
+            {
+                return false;
+            }
+
             var whiteToModel = fenPosition.IsWhiteToMove();
             var boardAscii = BoardToAscii.ToAscii(boardModel, whiteToModel);
             AsciiToColorfulOutput.AsciiToConsole(boardAscii);

diff --git a/RonSijm.ButtFish/ButtFishCore.cs b/RonSijm.ButtFish/ButtFishCore.cs
@@ -3,6 +3,7 @@
 using RonSijm.ButtFish.Encoders;
 using RonSijm.ButtFish.Models;
 using RonSijm.UCIEngineInterop.Core;
+using RonSijm.UCIEngineInterop.Exceptions;
 
 namespace RonSijm.ButtFish;
 
@@ -21,10 +22,9 @@ public ButtFishCore(Options options, ICharacterEncoder characterEncoder)
 
     public async Task Start()
     {
-        Console.WriteLine("Welcome to Buttfish!");
+        Colorful.Console.WriteLine("Welcome to Buttfish!", Color.GreenYellow);
         Console.WriteLine();
         Console.WriteLine($"Using Encoder: {_characterEncoder.GetType().Name}");
-        Console.WriteLine("Checking engines");
 
         var enginePath = EngineSelector.SelectEngine(_options.Engines);
 
@@ -41,22 +41,31 @@ public async Task Start()
 
         _iuciEngine = new UCIEngine(enginePath.Path);
 
+        Console.WriteLine();
+        Console.WriteLine();
+
         do
         {
             try
             {
-                Console.WriteLine();
                 Colorful.Console.WriteLine("Set the current chess FEN Position...", Color.Green);
                 var fenPosition = Console.ReadLine();
 
-                _iuciEngine.StartNewGame();
-                _iuciEngine.SetFenPosition(fenPosition);
-                Console.WriteLine();
+                // If you just send a whitespace, the engine keeps waiting for the rest of the command
+                if (string.IsNullOrWhiteSpace(fenPosition))
+                {
+                    Colorful.Console.WriteLine("You didn't have to press enter there...", Color.Orange);
+                    continue;
+                }
 
                 var success = FENToOutputFacade.PaintBoard(fenPosition);
 
                 if (success)
                 {
+                    _iuciEngine.StartNewGame();
+                    _iuciEngine.SetFenPosition(fenPosition);
+                    Console.WriteLine();
+
                     Console.WriteLine();
                     Console.WriteLine("Next Best Position:");
 
@@ -68,13 +77,38 @@ public async Task Start()
                     }
 
                     await SendNextMoveToDevice(nextPosition, device);
+                    Console.WriteLine();
+                }
+                else
+                {
+                    Colorful.Console.WriteLine("That doesn't look right to me...", Color.Red);
+                    Colorful.Console.Write("Try Again - ", Color.Green);
                 }
             }
+            // Error that happens when the chess-engine gets fucked up somehow.
+            catch(MaxTriesException e)
+            {
+                Colorful.Console.WriteLine("Error occurred.", Color.Red);
+                Colorful.Console.WriteLine(e, Color.Red);
+
+                Colorful.Console.WriteLine("Recycling chess engine...", Color.Green);
+                _iuciEngine = new UCIEngine(enginePath.Path);
+
+                // We don't automatically set the old FEN code, otherwise if you added a broken
+                // FEN code, the engine gets in a broken loop
+                Colorful.Console.WriteLine("Please try again", Color.Green);
+            }
             catch (Exception e)
             {
                 Console.WriteLine(); // Blank line because chess moves were not placed on a new line.
                 Colorful.Console.WriteLine("Error occurred.", Color.Red);
                 Colorful.Console.WriteLine(e, Color.Red);
+
+                if (!string.IsNullOrWhiteSpace(e.Source))
+                {
+                    Colorful.Console.WriteLine($"Source:{e.Source}", Color.Red);
+                }
+
                 Console.WriteLine("Sometimes the program can recover, otherwise it's probably better to restart.");
             }
         } while (true);
@@ -119,6 +153,6 @@ private async Task SendNextMoveToDevice(string nextPosition, IDeviceAbstraction
         }
 
         Console.WriteLine();
-        Console.WriteLine("Finished sending command to device.");
+        Colorful.Console.WriteLine("Finished sending command to device.", Color.Green);
     }
 }
diff --git a/RonSijm.ButtFish/DeviceDiscoveryManager.cs b/RonSijm.ButtFish/DeviceDiscoveryManager.cs
@@ -87,7 +87,8 @@ private static IDeviceAbstraction ListDiscoveredDevices(List<IDeviceAbstraction>
             return null;
         }
 
-        Console.WriteLine("Discovered the following devices:");
+        Console.WriteLine();
+        Colorful.Console.WriteLine("Discovered the following devices:", Color.Green);
 
         for (var index = 0; index < discoveredDevices.Count; index++)
         {
@@ -96,6 +97,7 @@ private static IDeviceAbstraction ListDiscoveredDevices(List<IDeviceAbstraction>
             Console.WriteLine(deviceAbstraction is YeelightDevice ? $"{(index + 1)} - Yeelight device: {deviceAbstraction}" : $"{(index + 1)} - Butt device: {deviceAbstraction}");
         }
 
+        Console.WriteLine();
         Colorful.Console.WriteLine("Which device do you want to use?", Color.Green);
         var deviceChoice = Console.ReadKey().Key.ToNumber();
 

diff --git a/RonSijm.UCIEngineInterop/Core/Stockfish.cs b/RonSijm.UCIEngineInterop/Core/Stockfish.cs
@@ -61,7 +61,8 @@ private bool IsReady()
         {
             ++tries;
 
-            if (UCIEngineProcess.ReadLine() == "readyok")
+            var engineReadLine = UCIEngineProcess.ReadLine();
+            if (engineReadLine == "readyok")
             {
                 return true;
             }