Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue3 Support #44

Open
dougalg opened this issue Dec 7, 2021 · 10 comments
Open

Vue3 Support #44

dougalg opened this issue Dec 7, 2021 · 10 comments
Labels
enhancement New feature or request released on @beta

Comments

@dougalg
Copy link
Contributor

dougalg commented Dec 7, 2021

Hi, I am wondering if there are any plans for vue3 support for this package? Thanks a lot

@RonaldJerez
Copy link
Owner

Hello, the current project I am using this on doesn’t have any plans to upgrade to vue 3 yet. It’s not in my immediate schedule but eventually I will.

@RonaldJerez RonaldJerez added the question Further information is requested label Dec 12, 2021
@andreasvirkus
Copy link

What about now? 👀

@kevinmelo
Copy link

What i did was changing the methods inside directive.js to the new ones for Vue3, until this lib supports Vue3

@RonaldJerez
Copy link
Owner

I honestly don't have a need for it yet, which is why I haven't prioritize it, but I did look into it briefly last year and stopped because styleguidest did not support vue 3 yet, and the documentations page requires it. I created an issue to see if anyone wanted to contribute and help us move to storybook which does support vue 3.

I'm more than open to contributions, even under beta if anyone wants to create a PR with the necessary changes for vue3.

@RonaldJerez RonaldJerez added the enhancement New feature or request label Oct 5, 2022
RonaldJerez added a commit that referenced this issue Oct 5, 2022
@github-actions
Copy link

github-actions bot commented Oct 5, 2022

🎉 This issue has been resolved in version 3.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@iyerusad
Copy link

"vue-input-facade": "version": "3.0.0-beta.2"
"vue": "version": "3.2.47"

Vue3 seems like it wanted below, particularly filter was throwing errors.
Vue3 main.js

import { createApp } from 'vue';
const app = createApp(App);

import { InputFacade, facade, filter } from 'vue-input-facade';
app.component('InputFacade', InputFacade);
app.directive('facade', facade);
app.config.globalProperties.$filters = {
  facade: filter
};

@RonaldJerez
Copy link
Owner

Ah yes, filters are not supported in vue3. That needs to be removed.

Robo-Rin added a commit to Robo-Rin/vue-input-facade that referenced this issue Jul 11, 2023
Vue 3 doesn't support Vue.filter and needed to be replaced by a standard utility function.

closes: RonaldJerez#44
Robo-Rin added a commit to Robo-Rin/vue-input-facade that referenced this issue Jul 11, 2023
Vue 3 doesn't support Vue.filter and needed to be replaced by a standard utility function.

closes RonaldJerez#44
Robo-Rin added a commit to Robo-Rin/vue-input-facade that referenced this issue Jul 11, 2023
Vue 3 doesn't support Vue.filter and needed to be replaced by a standard utility function.

closes RonaldJerez#44
Robo-Rin added a commit to Robo-Rin/vue-input-facade that referenced this issue Jul 11, 2023
Vue 3 doesn't support Vue.filter and needed to be replaced by a standard utility function.

closes RonaldJerez#44
Robo-Rin added a commit to Robo-Rin/vue-input-facade that referenced this issue Jul 12, 2023
Vue 3 doesn't support Vue.filter anymore but we can use the masker directly instead.

closes RonaldJerez#44
RonaldJerez pushed a commit that referenced this issue Jul 12, 2023
Vue 3 doesn't support Vue.filter anymore but we can use the masker directly instead.

closes #44
@github-actions
Copy link

🎉 This issue has been resolved in version 3.0.0-beta.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@simonmaass
Copy link

When using v3 and nuxt 3.6.5 i get the following error:

Named export 'facade' not found. The requested module 'vue-input-facade' is a CommonJS module, which may not support all module.exports as named exports.

I created a pugin as follows:

import { facade } from 'vue-input-facade'

export default defineNuxtPlugin((nuxtApp) => {
  nuxtApp.vueApp.directive('facade', facade)
})

Robo-Rin added a commit to Robo-Rin/vue-input-facade that referenced this issue Dec 28, 2023
Upgrades dependencies, migrates to storybook + vite, removes default export.

BREAKING CHANGE: Users will have to use es6-style named imports instead.

closes RonaldJerez#44
Robo-Rin pushed a commit to Robo-Rin/vue-input-facade that referenced this issue Dec 29, 2023
Upgrades dependencies, migrates to storybook + vite, removes default export.

BREAKING CHANGE: Users will have to use es6-style named imports instead.

closes RonaldJerez#44
Robo-Rin pushed a commit to Robo-Rin/vue-input-facade that referenced this issue Dec 29, 2023
Upgrades dependencies, migrates to storybook + vite, removes default export.

BREAKING CHANGE: Users will have to use es6-style named imports instead.

closes RonaldJerez#44
Robo-Rin added a commit to Robo-Rin/vue-input-facade that referenced this issue Dec 29, 2023
Upgrades dependencies, migrates to storybook + vite, removes default export.

BREAKING CHANGE: Users will have to use es6-style named imports instead.

closes RonaldJerez#44
Robo-Rin added a commit to Robo-Rin/vue-input-facade that referenced this issue Dec 29, 2023
Upgrades dependencies, migrates to storybook + vite, removes default export.

BREAKING CHANGE: Users will have to use es6-style named imports instead.

closes RonaldJerez#44
Robo-Rin added a commit to Robo-Rin/vue-input-facade that referenced this issue Dec 29, 2023
Upgrades dependencies, migrates to storybook + vite, removes default export.

BREAKING CHANGE: Users will have to use es6-style named imports instead.

closes RonaldJerez#44
@RonaldJerez RonaldJerez removed the question Further information is requested label Jan 4, 2024
Robo-Rin pushed a commit to Robo-Rin/vue-input-facade that referenced this issue Jan 4, 2024
Robo-Rin added a commit to Robo-Rin/vue-input-facade that referenced this issue Jan 4, 2024
Vue 3 doesn't support Vue.filter anymore but we can use the masker directly instead.

closes RonaldJerez#44
Robo-Rin added a commit to Robo-Rin/vue-input-facade that referenced this issue Jan 4, 2024
Upgrades dependencies, migrates to storybook + vite, removes default export.

BREAKING CHANGE: Users will have to use es6-style named imports instead.

closes RonaldJerez#44, closes RonaldJerez#52
Robo-Rin added a commit to Robo-Rin/vue-input-facade that referenced this issue Jan 4, 2024
Upgrades dependencies, migrates to storybook + vite, removes default export.

BREAKING CHANGE: Users will have to use es6-style named imports instead.

closes RonaldJerez#44, closes RonaldJerez#52
RonaldJerez pushed a commit that referenced this issue Jan 4, 2024
Upgrades dependencies, migrates to storybook + vite, removes default export.

BREAKING CHANGE: Users will have to use es6-style named imports instead.

Also merges in changes from upstream master since beta branch diverged.

closes #44, closes #52

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Sarah Umi Leventhal <35374315+Umi8Umi@users.noreply.github.com>
Co-authored-by: Sarah Leventhal <sarah.leventhal@mastercard.com>
Co-authored-by: Ronald Jerez <ronald.jerez@mastercard.com>
Co-authored-by: Reuk Bundara <bundarareuk@gmail.com>
Copy link

github-actions bot commented Jan 4, 2024

🎉 This issue has been resolved in version 3.0.0-beta.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released on @beta
Projects
None yet
Development

No branches or pull requests

6 participants