fix: Support RegionPlugin UltimateClaims v2 and v1
#200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With v2 the package changed because Songoda renamed to Craftaro at one point in time. This fixes a `ClassNotFoundException` when using v2 of the plugin. The commit also refactors the code a bit as the `UltimateClaims#getInstance()` method is marked as deprecated and will be removed in the future.
TechnicallyCoded
requested changes
Mar 27, 2024
| // NOT TESTED (3.1.0) | ||
| // UltimateClaims (v1.6.1) - Abandoned | ||
| // https://songoda.com/marketplace/product/ultimateclaims-the-ultimate-claiming-plugin.65 | ||
| // TESTED (v2.2.0) |
There was a problem hiding this comment.
This should be 3.6.12
| // https://songoda.com/marketplace/product/ultimateclaims-the-ultimate-claiming-plugin.65 | ||
| // TESTED (v2.2.0) | ||
| // UltimateClaims (v2.2.0 + v1.10.4) | ||
| // https://craftaro.com/marketplace/product/65 |
There was a problem hiding this comment.
Please leave both links for where to find each version of the plugin. If the resource no longer exists, please leave a link to the last commit before v2. And ensure that you specify which link is for which version.
Comment on lines
+35
to
+37
| return Class.forName("com.craftaro.ultimateclaims.UltimateClaims"); // v2 | ||
| } catch (ClassNotFoundException ignore) { | ||
| return Class.forName("com.songoda.ultimateclaims.UltimateClaims"); // v1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With UltimateClaims v2 the package changed because Songoda renamed to Craftaro at one point.
This fixes a
ClassNotFoundExceptionwhen using v2 of the plugin. The commit also refactors the code a bit as theUltimateClaims#getInstance()method is marked as deprecated and will be removed in the future.