Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update mails format #70

Merged
merged 10 commits into from
May 20, 2024
Merged

Conversation

Goodmain
Copy link
Contributor

Ref: #66

@Goodmain Goodmain linked an issue Feb 21, 2024 that may be closed by this pull request
@Goodmain Goodmain changed the title refactor: update mails format WIP: refactor: update mails format Feb 21, 2024
@Goodmain Goodmain requested a review from DenTray March 19, 2024 17:38
@Goodmain Goodmain changed the title WIP: refactor: update mails format refactor: update mails format Mar 19, 2024
tests/Support/InitCommandMockTrait.php Outdated Show resolved Hide resolved
app/Mail/BaseMail.php Show resolved Hide resolved
@Goodmain Goodmain requested a review from DenTray March 21, 2024 20:51
Copy link
Collaborator

@DenTray DenTray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Goodmain could you please check test coverage?

@Goodmain Goodmain requested a review from DenTray April 3, 2024 05:35
@Goodmain
Copy link
Contributor Author

Goodmain commented Apr 3, 2024

@DenTray I fixed an issue with coverage

Copy link
Collaborator

@DenTray DenTray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed let's test empty mail attachments

DenTray
DenTray previously approved these changes May 20, 2024
@DenTray DenTray merged commit d3c69a3 into development May 20, 2024
1 of 2 checks passed
@Goodmain Goodmain deleted the refactoring-mail-classes branch June 14, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mailer uses a 'default' queue instead of 'mails'
2 participants