-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#82: Moved status api out of versioning routes #83
#82: Moved status api out of versioning routes #83
Conversation
b056dcc
to
e98d178
Compare
tests/StatusTest.php
Outdated
@@ -10,7 +10,7 @@ class StatusTest extends TestCase | |||
{ | |||
public function testStatusOk() | |||
{ | |||
$response = $this->json('get', '/status'); | |||
$response = $this->json('get', '/status', [], [], 0, false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$response = $this->json('get', '/status', [], [], 0, false); | |
$response = $this->get('/status'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
tests/StatusTest.php
Outdated
@@ -23,7 +23,7 @@ public function testStatusServiceUnavailable() | |||
DB::shouldReceive('connection')->andReturn($connection); | |||
DB::shouldReceive('getPdo')->andThrow(Exception::class); | |||
|
|||
$response = $this->json('get', '/status'); | |||
$response = $this->json('get', '/status', [], [], 0, false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$response = $this->json('get', '/status', [], [], 0, false); | |
$response = $this->get('/status'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
tests/TestCase.php
Outdated
@@ -67,10 +67,13 @@ public function call($method, $uri, $parameters = [], $cookies = [], $files = [] | |||
return parent::call($method, $uri, $parameters, $cookies, $files, $server, $content); | |||
} | |||
|
|||
public function json($method, $uri, array $data = [], array $headers = [], $options = 0, ?VersionEnum $apiVersion = null): TestResponse | |||
public function json($method, $uri, array $data = [], array $headers = [], $options = 0, VersionEnum|bool|null $apiVersion = null): TestResponse |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use get
method for the status tests instead of extending json
method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
No description provided.