Clone user pre send to actingas #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DenTray
requested changes
May 17, 2024
tests/AuthTestTraitTest.php
Outdated
Comment on lines
54
to
64
| $mockedUser = new MockAuthUser(); | ||
| $mockedUser->someIntProperty = 0; | ||
|
|
||
| $this->actingAs($mockedUser); | ||
|
|
||
| $user = Auth::user(); | ||
| $user->someIntProperty = 1; | ||
|
|
||
| $this->actingAs($mockedUser); | ||
|
|
||
| $this->assertEquals(0, Auth::user()->someIntProperty); |
There was a problem hiding this comment.
let's try to test it like this
Suggested change
| $mockedUser = new MockAuthUser(); | |
| $mockedUser->someIntProperty = 0; | |
| $this->actingAs($mockedUser); | |
| $user = Auth::user(); | |
| $user->someIntProperty = 1; | |
| $this->actingAs($mockedUser); | |
| $this->assertEquals(0, Auth::user()->someIntProperty); | |
| $mockedUser = new MockAuthUser(); | |
| $this->actingAs($mockedUser); | |
| $this-> assertNotSame($mockedUser, Auth::user()); |
There was a problem hiding this comment.
This work is great! Thanks.
DenTray
requested changes
May 20, 2024
DenTray
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added method actingAs to trait AuthTestTrait, this solution solve problem when test user define as static in tests. This protect for change user object on batch testing.