Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: documentation creates only for the last test case #126

Merged
merged 1 commit into from
May 2, 2024

Conversation

Goodmain
Copy link
Contributor

Description

The documentation generates only for the single test case. So the final documentation.json file contains information from the last test case. The reason is the incorrect event of PHPUnit. I changed PHPUnit\Event\Test\AfterLastTestMethodFinished to PHPUnit\Event\Application\Finished and as a result, a subscriber will run only when all tests finish.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@Goodmain Goodmain requested a review from DenTray April 28, 2024 06:29
Copy link

sonarcloud bot commented Apr 28, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@DenTray DenTray merged commit a9b2d6a into master May 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants