Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce reliance on network in tests #64

Merged
merged 27 commits into from
Jan 21, 2020

Conversation

jfinkhaeuser
Copy link
Collaborator

Fixes #46.

Changes proposed in this PR:

  • Add requires_network mark to tests requiring the network. We can then run tests with pytest -m "no requires_network".
  • Mock some other requests in tests.

@jfinkhaeuser

…So for travis to cut off things at the space suggests it doesn't treat it as quoted, maybe?
travis. Can we use a bespoke script step for each job?
… line that the latest release does not contain any longer
@jfinkhaeuser
Copy link
Collaborator Author

So, looks like pytest just fails on this line. It's got nothing to do with Python 3.5 that I can see, so I'm going to enable those builds again, and merge with failures.

Sucks, but there you go.

@jfinkhaeuser jfinkhaeuser marked this pull request as ready for review January 21, 2020 10:18
@jfinkhaeuser jfinkhaeuser merged commit afc8c68 into master Jan 21, 2020
@jfinkhaeuser jfinkhaeuser deleted the 46-fix-reliance-on-network-in-tests branch January 21, 2020 10:19
jfinkhaeuser added a commit that referenced this pull request Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI tests test_convert_defaults and test_convert_output fail without network
1 participant