Swift 3 #103

phatblat · 2016-07-03T04:35:28Z

Ran the Swift 3 migration tool and updated the RealmSwift API for the changes in master.

🚫 Currently blocked by rdar://27141382. Hopefully, Xcode 8b2 will fix these errors
⚠️ Depends on unreleased Swift 3 changes for RealmSwift in the master branch of realm-cocoa
⚠️ Depends on Swift 3 RBQSafeRealmObject#2. ~~Will redo submodule commit after dependent PR is merged.~~

Dependendencies now integrated using CocoaPods instead of git submodules

Swift 3 fixes

Pointing to phatblat/swift-3 branch

warning: FetchedResultsController.swift:93:198: Extraneous duplicate parameter name; 'newIndexPath' already has an argument label

phatblat · 2016-07-06T01:21:15Z

Strange build issue is resolved in Xcode 8b2 (8S162m) 🎉

RyanCodes · 2016-09-13T01:56:30Z

What is the status of this PR? Will this be released soon?

bigfish24 · 2016-09-20T05:23:45Z

Sorry I will try to pick up on this next week. Realm is announcing something new next week and I have been heads down all summer.

cezarywojcik · 2016-10-07T06:46:44Z

@phatblat @bigfish24 any ETA on the Swift 3 support?

syky27 · 2016-10-14T14:26:09Z

Can someone take a look at this perhaps?

Thank you for support!

syky27 · 2016-10-27T21:33:59Z

Ok, It seems that no one is willing to merge this.

@phatblat Thank you very much for this update, I was unfortunately unable to get this working with your forked pods, could you point me to correct way how to get this working temporarily?

Thank you

phatblat · 2016-10-27T22:35:38Z

@syky27 You can install an unreleased version of a pod from a branch using the following:

pod 'RBQFetchedResultsController', git: 'https://github.com/phatblat/RBQFetchedResultsController.git', branch: 'swift-3'

phatblat · 2016-10-27T22:39:01Z

Almost forgot, since RBQSafeRealmObject is a dependency of this library and its Swift 3 migration is still (in-progress](Roobiq/RBQSafeRealmObject#2), you'll want to include it from a branch as well, but that dependency should be before RBQFetchedResultsController, so that it uses the modified version instead of a released version.

pod 'RBQSafeRealmObject', git: 'https://github.com/phatblat/RBQSafeRealmObject.git', branch: 'swift-3'
pod 'RBQFetchedResultsController', git: 'https://github.com/phatblat/RBQFetchedResultsController.git', branch: 'swift-3'

bigfish24 · 2016-10-27T22:43:57Z

@phatblat and @syky27 sorry this has sat idle for so long. Not much I can say other than I sincerely apologize. Added @phatblat as a contributor to both repos... if things are ready do you want to merge, if not I can do so too?

syky27 · 2016-10-27T22:46:58Z

Well this is getting better, @phatblat I was trying that exactly as you suggested now, but I still could not build because some error, and now when I wanted to give you the error, cocoapods are acting crazy, I need to do gem cleanup in a sec, cannot really do it now... I will keep you posted.

@bigfish24 Sorry for being such pain in the ass.

bigfish24 · 2016-10-27T22:48:54Z

Sorry for being such pain in the ass

Not in the slightest! This is entirely my fault and I should have addressed it far sooner.

syky27 · 2016-10-27T23:03:03Z

@phatblat So I fixed my cocoapods installation the build error I am getting is:

/Users/syky/optify/optify-ios/Pods/RBQFetchedResultsController/RBQFetchedResultsController/Source/CacheObjects/RBQObjectCacheObject.h:10:9: 'RBQSafeRealmObject.h' file not found

In RBQObjectCacheObject.h file.

phatblat · 2016-10-28T03:43:41Z

@syky27 do you have use_frameworks! In your Podfile? That import needs to be changed to work with frameworks/modules. I'll update it tomorrow.

phatblat · 2016-10-28T03:45:26Z

@bigfish24 thanks for adding me as a contributor! I'll double check my changes, test them in Xcode 8.1 and merge when things look good.

syky27 · 2016-10-31T13:50:24Z

Hi, @phatblat did you find a time to get to this?

syky27 · 2016-11-02T18:48:40Z

Could someone please merge this? Or at least provide me with solution? @phatblat you said that the import needs to be changed but you did not provide me with solution.

I know that I am really pressing on this, it's kinda critical for me.

Thank you in advance.

syky27 · 2016-11-22T20:37:36Z

And when I build and run the project I am getting SIGABRT in RealmConfiguration.swift:180

With following:

Could not cast value of type 'RBQSectionCacheObject' (0x10e01b560) to 'RealmSwift.Object' (0x10ea16390).

EDIT: Just realizing this is Realm thing.... I will try to update it I might running wrong version.... but shouldn't RBQFetchedResultsController have dependency on Realm, and if so is't it fetching wrong version.... 🤔

-- Runnning Realm 2.1.0

EDIT2: I guess It is too late for my brain it is just not working.... EDIT above is complete nonsense, sorry. The problem is obviously described above. I either cannot read English anymore or my prescription glasses ain't working.

ccheungfb · 2016-11-28T14:49:51Z

What are the missing pieces to get this change merged? This is the last piece that our project needs to fully convert to Swift 3 / xCode 8.

generalpf · 2016-12-01T14:56:48Z

This PR is the only thing keeping me from choosing Realm for my projects at work and at home. I know, it's open source and all that, but unless Realm has a drop-in replacement for the fetched results controller, it's a really tough sell to the team.

It would be nice if the nice folks at Realm could supply this and not rely on a third-party to provide it.

phatblat · 2016-12-01T17:45:33Z

Sorry for the delay in finishing this up. I believe all the changes necessary are done, I just haven't been able to test it to verify that everything is working correctly. I'll plan to merge this tomorrow, allowing one last day for feedback.

syky27 · 2016-12-01T17:47:13Z

@phatblat see my last comment I am getting an error

phatblat · 2016-12-01T21:22:02Z

Ah, I'm getting the same error when running the "Swift" (no suffix) example project.

Could not cast value of type 'RBQSectionCacheObject' (0x1096e5a98) to 'RealmSwift.Object' (0x10a19e390).

phatblat · 2016-12-01T21:30:42Z

It's blowing up in toRLMConfiguration when retrieving configuration.objectTypes in order to copy over to rlmConfiguration.objectClasses. It's trying to cast RBQSectionCacheObject to RealmSwift.Object, but it is a subclass of RLMObject.

It looks like RealmSwift assumes that all objects that are part of the schema will be instances of RealmSwift.Object with no mix-and-match of the objc version of the framework. I hope this doesn't mean all the cache objects need to be reimplemented in Swift.

bigfish24 · 2016-12-01T21:37:28Z

Ok will look into, I am sure I can find a way to convert between the types.

phatblat · 2016-12-01T21:39:49Z

Too bad Realm isn't casting to RLMObjectBase as it's a common super class.

RealmSwiftObject == RealmSwift.Object

phatblat · 2016-12-01T21:48:07Z

What's the reason that these cache objects extend RLMObject? Seems like they aren't part of the schema and don't need to be persisted, just stored temporarily in memory.

phatblat · 2016-12-01T21:50:46Z

Nevermind. I see now that they are being stored in a cacheRealm.

bigfish24 · 2016-12-02T06:37:32Z

This is actually an odd bug because typically at Realm we don't recommend to mix ObjC and Swift together, so the ObjC class definition actually doesn't play nice with the objectTypes getter in the Realm Swift framework. However, what's ironic is that you wouldn't actually hit this when using RBQFetchedResultsController as a framework because the cache object models would be isolated in the framework.... however, in the Swift example the files are included directly in the project!

bigfish24 · 2016-12-02T07:15:40Z

Ok this is really ugly but using Swift's limited reflection here is how I could get around it:

// Hack to get around issue with cache objects appearing in Realm
// when building RBQFRC not as a framework
let mirror = Mirror(reflecting: configuration)
for child in mirror.children {
    if "customSchema" == child.label {
        let customSchema = child.value as! RLMSchema
        
        let schemaSubset = customSchema.objectSchema.filter({ (objectSchema) -> Bool in
            let cacheObjectNames = ["RBQControllerCacheObject",
                                    "RBQObjectCacheObject",
                                    "RBQSectionCacheObject"]
            
            if cacheObjectNames.contains(objectSchema.objectName) {
                return false
            }
            
            return true
        })
        
        rlmConfiguration.objectClasses = schemaSubset.map { $0.objectClass }
    }
}

bigfish24 · 2016-12-02T07:21:42Z

RBQFetchedResultsController/Source/Swift/Utilities.swift

+            rlmConfiguration.syncConfiguration = RLMSyncConfiguration(user: syncConfig.user, realmURL: syncConfig.realmURL)
+        }
+
+        if let objectTypes = configuration.objectTypes {


replace with this for now:

// Hack to get around issue with cache objects appearing in Realm // when building RBQFRC not as a framework let mirror = Mirror(reflecting: configuration) for child in mirror.children { if "customSchema" == child.label { let customSchema = child.value as! RLMSchema let schemaSubset = customSchema.objectSchema.filter({ (objectSchema) -> Bool in let cacheObjectNames = ["RBQControllerCacheObject", "RBQObjectCacheObject", "RBQSectionCacheObject"] if cacheObjectNames.contains(objectSchema.objectName) { return false } return true }) rlmConfiguration.objectClasses = schemaSubset.map { $0.objectClass } } }

bigfish24 · 2016-12-02T07:24:05Z

With my change this should be good to go to merge 👍

bigfish24 · 2016-12-02T17:27:57Z

We can remove this hack once a new release of Realm Swift is released that exposes converter functions to support interoperability of Swift and ObjC Realm objects: https://github.com/realm/realm-cocoa/blob/master/RealmSwift/ObjectiveCSupport.swift#L139-L147

jpsim · 2016-12-02T17:43:59Z

Barring surprises, we're planning on releasing Realm Swift 2.1.1 today.

jpsim · 2016-12-03T01:46:57Z

2.1.1 is out: https://github.com/realm/realm-cocoa/releases/tag/v2.1.1

bigfish24 · 2016-12-04T02:34:34Z

Let's get this fix in for backwards compatibility and then update to use new 2.1.1 APIs

phatblat · 2016-12-05T03:35:52Z

Sounds good

…uilding RBQFRC not as a framework

phatblat · 2016-12-05T03:45:07Z

LGTM. Thanks everyone for helping with this long-running PR!

bigfish24 · 2016-12-05T03:49:32Z

👏🎉🎉

phatblat added 6 commits July 1, 2016 20:09

TEMP: Point submodules at local paths for development

e1f777f

Update RBWSafeRealmObject submodule

c28ceeb

Swift 3 fixes

Run Swift 3 migration tool

55a1503

Update RBQSafeRealmObject

89fdbf1

Pointing to phatblat/swift-3 branch

Removed extraneous duplicate 'newIndexPath' parameter name

cf1feea

warning: FetchedResultsController.swift:93:198: Extraneous duplicate parameter name; 'newIndexPath' already has an argument label

Xcode 8 recommended settings

266f2c6

phatblat mentioned this pull request Jul 5, 2016

[WIP] Swift 3 phatblat/ABFRealmMapView#1

Closed

phatblat added 5 commits October 9, 2016 14:25

Ignore and stop tracking xcscmblueprint file

0328961

Set SWIFT_VERSION to 3.0

b6bb22c

Ignore Carthage folder

d7d053b

Set .swift-version to 3.0

e8a7504

Swift and Realm API changes

3514716

syky27 mentioned this pull request Oct 20, 2016

Swift 3 Roobiq/RBQSafeRealmObject#2

Merged

Add missing dependencies on RBQSafeRealmObject and SafeRealmObject

6776c96

bigfish24 reviewed Dec 2, 2016

View reviewed changes

phatblat added 2 commits December 4, 2016 20:37

Hack to get around issue with cache objects appearing in Realm when b…

0d60ee9

…uilding RBQFRC not as a framework

Clean up hack

9e33894

phatblat changed the title ~~[WIP] Swift 3~~ Swift 3 Dec 5, 2016

Remove obsolete comments

8254a40

phatblat merged commit a861b89 into Roobiq:master Dec 5, 2016

phatblat deleted the swift-3 branch December 5, 2016 03:45

phatblat mentioned this pull request Dec 5, 2016

RealmSwift 2.1.1 #111

Closed

jpsim mentioned this pull request Dec 7, 2016

Swift Compiler Error "Type 'Any' does not conform to protocol 'AnyObject'" realm/realm-swift#4419

Closed

Swift 3 #103

Swift 3 #103

Conversation

phatblat commented Jul 3, 2016 • edited Loading

phatblat commented Jul 6, 2016

RyanCodes commented Sep 13, 2016

bigfish24 commented Sep 20, 2016

cezarywojcik commented Oct 7, 2016

syky27 commented Oct 14, 2016

syky27 commented Oct 27, 2016

phatblat commented Oct 27, 2016

phatblat commented Oct 27, 2016

bigfish24 commented Oct 27, 2016

syky27 commented Oct 27, 2016

bigfish24 commented Oct 27, 2016 • edited Loading

syky27 commented Oct 27, 2016

phatblat commented Oct 28, 2016

phatblat commented Oct 28, 2016

syky27 commented Oct 31, 2016

syky27 commented Nov 2, 2016

syky27 commented Nov 22, 2016 • edited Loading

ccheungfb commented Nov 28, 2016

generalpf commented Dec 1, 2016

phatblat commented Dec 1, 2016

syky27 commented Dec 1, 2016

phatblat commented Dec 1, 2016

phatblat commented Dec 1, 2016

bigfish24 commented Dec 1, 2016

phatblat commented Dec 1, 2016

phatblat commented Dec 1, 2016

phatblat commented Dec 1, 2016

bigfish24 commented Dec 2, 2016 • edited Loading

bigfish24 commented Dec 2, 2016 • edited Loading

bigfish24 Dec 2, 2016

Choose a reason for hiding this comment

bigfish24 commented Dec 2, 2016

bigfish24 commented Dec 2, 2016

jpsim commented Dec 2, 2016

jpsim commented Dec 3, 2016

bigfish24 commented Dec 4, 2016

phatblat commented Dec 5, 2016

phatblat commented Dec 5, 2016

bigfish24 commented Dec 5, 2016

phatblat commented Jul 3, 2016 •

edited

Loading

bigfish24 commented Oct 27, 2016 •

edited

Loading

syky27 commented Nov 22, 2016 •

edited

Loading

bigfish24 commented Dec 2, 2016 •

edited

Loading

bigfish24 commented Dec 2, 2016 •

edited

Loading