W3Schools Plugin #88
W3Schools Plugin #88
Conversation
|
Main concerns are copy and resource links. Specifically the use of w3fools for the main link, and the lines for MySQL and XML. There's also currently no support for specific W3 articles past the initial category. |
|
|
||
| if( | ||
| !preg_match_all( | ||
| '/' . self::BAD_HOST_PATTERN . '\/(' . implode('|', $categoryNames) . ')\//i', |
There was a problem hiding this comment.
Since you need to match literal slashes, why not use a different delimiter?
e.g. '#' . self::BAD_HOST_PATTERN . '/(' . implode('|', $categoryNames) . ')/#i'
| 'css' => '[Check the Mozilla Developer Network CSS documentation](https://developer.mozilla.org/docs/Web/CSS) for help with CSS.', | ||
| 'js' => '[Check the Mozilla Developer Network JS documentation](https://developer.mozilla.org/docs/Web/JavaScript) for help with JavaScript.', | ||
| 'sql' => '[Check MySQL\'s official MySQL documentation](http://dev.mysql.com/doc/) for more information.', | ||
| 'php' => '[Check the official PHP Documentation](http://php.net/docs.php) for help with PHP.', |
There was a problem hiding this comment.
| 'js' => '[Check the Mozilla Developer Network JS documentation](https://developer.mozilla.org/docs/Web/JavaScript) for help with JavaScript.', | ||
| 'sql' => '[Check MySQL\'s official MySQL documentation](http://dev.mysql.com/doc/) for more information.', | ||
| 'php' => '[Check the official PHP Documentation](http://php.net/docs.php) for help with PHP.', | ||
| 'bootstrap' => '[Check the official Bootstrap Documentation](http://getbootstrap.com/getting-started/) for help with the Bootstrap framework.', |
There was a problem hiding this comment.
| 'sql' => '[Check MySQL\'s official MySQL documentation](http://dev.mysql.com/doc/) for more information.', | ||
| 'php' => '[Check the official PHP Documentation](http://php.net/docs.php) for help with PHP.', | ||
| 'bootstrap' => '[Check the official Bootstrap Documentation](http://getbootstrap.com/getting-started/) for help with the Bootstrap framework.', | ||
| 'jquery' => '[Check the official jQuery API Documentation](http://api.jquery.com/) for help with the jQuery library.', |
| 'html' => '[Check the Mozilla Developer Network HTML documentation](https://developer.mozilla.org/docs/Web/HTML) for help with HTML.', | ||
| 'css' => '[Check the Mozilla Developer Network CSS documentation](https://developer.mozilla.org/docs/Web/CSS) for help with CSS.', | ||
| 'js' => '[Check the Mozilla Developer Network JS documentation](https://developer.mozilla.org/docs/Web/JavaScript) for help with JavaScript.', | ||
| 'sql' => '[Check MySQL\'s official MySQL documentation](http://dev.mysql.com/doc/) for more information.', |
There was a problem hiding this comment.
Also note that W3S "sql" chapter is not specific to MySQL, also covers other horrifyingly shit database engines as well \o/
There was a problem hiding this comment.
Indeed, I have no idea on what can be considered a good MySQL reference out there, initial searching didn't produce anything fantastic.
There was a problem hiding this comment.
I think the official manual is a good place to start with anything. There's also this for specifically PDO/mysql.
…ssion matching changed to '#' from '/'. * Metric not accurate.
|
Additional commit based on feedback. 🎆 |
|
Away for the weekend but I'll sort it out next week. |
PR For Issue #80.
Would like some initial eyes on this first, tests are passing but I aim to add more for coverage tomorrow.