Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use wdio configPath relative from workspace root to run wdio #14

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

Roozenboom
Copy link
Owner

Current Behavior

When the e2e executor is used it runs wdio with a generated config file. This file is stored in the root of the e2e project and is referenced only by the file name. We create a child process to run wdio and configure the working directory (cwd) to the e2e project. With NPM this worked as expected, but when the project is using yarn as a package manager the working directory is not set correctly, resulting in an error Could not execute "run" due to missing configuration file

Expected Behavior

This PR changed how we configure the generated configuration in the child process command. Instead of the file name we use the file path relative to the workspace root. We also update the import path for the base configuration to always be relative to the generated config location.

Related Issue(s)

Fixes #13

@Roozenboom Roozenboom merged commit 5da70ae into main Aug 25, 2023
3 checks passed
@Roozenboom Roozenboom deleted the bugfix/use-project-wdio-config-path branch August 25, 2023 15:58
@nx-cloud
Copy link

nx-cloud bot commented Aug 25, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 28acfaa. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 4 targets

Sent with 💌 from NxCloud.

@github-actions
Copy link

🎉 This PR is included in version 1.5.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Could not execute "run" due to missing configuration, file
1 participant