Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat tutorials and delete docker #115

Merged
merged 9 commits into from
Aug 10, 2023
Merged

Reformat tutorials and delete docker #115

merged 9 commits into from
Aug 10, 2023

Conversation

benoit9126
Copy link
Member

@benoit9126 benoit9126 commented Aug 8, 2023

  • Reformat tutorials notebook into markdown files
  • Split the "Advanced tutorial" into several files
  • Rename short circuit into short-circuit everywhere
  • Delete the notebooks
  • Delete the docker container build (too complicated and useless with a working conda installation)

@benoit9126 benoit9126 added documentation Improvements or additions to documentation enhancement New feature or request labels Aug 8, 2023
@benoit9126 benoit9126 self-assigned this Aug 8, 2023
@benoit9126 benoit9126 marked this pull request as ready for review August 9, 2023 07:36
@benoit9126 benoit9126 changed the title Reformat tutorials Reformat tutorials and delete docker Aug 9, 2023
Copy link
Member

@alihamdan alihamdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I left some suggestions.

doc/usage/Getting_Started.md Outdated Show resolved Hide resolved
doc/usage/Getting_Started.md Outdated Show resolved Hide resolved
doc/usage/Getting_Started.md Outdated Show resolved Hide resolved
doc/usage/Getting_Started.md Outdated Show resolved Hide resolved
doc/usage/Getting_Started.md Outdated Show resolved Hide resolved
doc/usage/Connecting_Elements.md Outdated Show resolved Hide resolved
doc/usage/Flexible_Loads.md Outdated Show resolved Hide resolved
doc/usage/Flexible_Loads.md Show resolved Hide resolved
doc/usage/Short_Circuit.md Outdated Show resolved Hide resolved
doc/usage/Short_Circuit.md Outdated Show resolved Hide resolved
doc/usage/Getting_Started.md Outdated Show resolved Hide resolved
doc/usage/Getting_Started.md Show resolved Hide resolved
doc/usage/Getting_Started.md Outdated Show resolved Hide resolved
@benoit9126 benoit9126 merged commit fcc0b2b into develop Aug 10, 2023
4 checks passed
@benoit9126 benoit9126 deleted the tutorials branch August 10, 2023 08:46
@benoit9126 benoit9126 mentioned this pull request Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants