-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation #97
Documentation #97
Conversation
@alihamdan @Saelyos I have improved what I could. Now, there are remaining TODO (single-phase transformer, split-phase transformer, Switch example, etc) that remain in the documentation. Could you please read it when you have time? |
It is the name displayed on PyPI https://pypi.org/project/roseau-load-flow/ and conda-forge https://anaconda.org/conda-forge/roseau-load-flow and the name displayed by `pip list`. Avoid confusing beginners by mixing names.
This is to avoid future dead links
@benoit9126 this is ready now. We have models docs and usage examples for all elements. I also fixed all the links 🤞🏻 (the relative link hack you used earlier in the code docstring does not always work, it depends on the page you are in when you click the link, for example, works from |
I will add some other modifications in this branch (Google Analytics, etc). @alihamdan @Saelyos Thanks! 👍 Small question when reading the documentation. In such example, I think there is a problem with delta connected voltage source (extracted from the example on the page "three-phase transformer"): # Create a MV bus
bus_mv = Bus(id="bus_mv", phases="abc")
# ....
# Create a voltage source and connect it to the MV bus
voltages = 20e3 * np.exp([0, -2j * np.pi / 3, 2j * np.pi / 3])
vs = VoltageSource(id="vs", bus=bus_mv, voltages=voltages) As it is a delta voltage source, its voltages should have been: import numpy as np
from roseau.load_flow.converters import calculate_voltages
potentials = 20e3/np.sqrt(3) * np.exp([0, -2j * np.pi / 3, 2j * np.pi / 3])
voltages = calculate_voltages(potentials, "abc")
# array([ 17320.50807569+10000.j, 0. -20000.j, -17320.50807569+10000.j]) |
I think both are correct. It depends on what you'd like to be your "reference" (angle 0 with the potential ref). At the end, voltage is relative and the results you get will depend on your definition but both are correct.
In this example, the voltage
While in this example In both cases you get a 20kV source with 120° between the phases. |
Improvement of the documentation. Creation of a
models
section #69.