Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tm4e upstream, fix issues with symbol matching, and improve completion item list sorting #538

Merged
merged 9 commits into from
Jan 30, 2024
Merged

Update tm4e upstream, fix issues with symbol matching, and improve completion item list sorting #538

merged 9 commits into from
Jan 30, 2024

Conversation

dingyi222666
Copy link
Contributor

@dingyi222666 dingyi222666 commented Jan 29, 2024 •
edited

This pull request makes the following changes:

  • Update the upstream of tm4e, remove the guava dependency, and follow the requested changes in TM4E copyright/license headers changed #537.
  • Fix the issue that symbol matching was not enabled by default in the textmate module, and fix the issue that auto-surround did not work properly.
  • Fix the errors mentioned in SDK 24 #532 and Animation delayed in AutoCompletionWindow  #420.
  • Fix the issue that the completion list was not sorted correctly, and now the completion list should be normal (I apologize for taking so long to fix this low-level error)

@dingyi222666
feat(lang-textmate): merge upstream of tm4e update & fix Rosemoe#537
c51eb16 
Update taken from eclipse/tm4e@1d2beb8
@dingyi222666
fix(editor): fix Rosemoe#532
035eb88
@dingyi222666
fix(editor): fix Rosemoe#420
5bd5602
@dingyi222666
fix(lang-textmate): enable symbol pair matching by default
87696ea
@dingyi222666
fix(lang-textmate): make auto surrounding work properly
d24c5d7
@dingyi222666
fix(editor): change the completion item order from ascending to desce…
50d8cc8 
…nding

We Use fuzzyScore to generate scores between completions and input text, and sort them accordingly.
Previously, the scores were sorted in ascending order, which was incorrect since higher scores should be closer to the input text. I apologize for taking so long to realize this mistake.
@dingyi222666 dingyi222666 changed the title feat(lang-textmate): merge upstream of tm4e update & fix #537 Update textmate upstream, fix issues with symbol matching, and improve completion item list sorting Jan 29, 2024
@dingyi222666 dingyi222666 marked this pull request as ready for review January 29, 2024 17:40
@dingyi222666 dingyi222666 changed the title Update textmate upstream, fix issues with symbol matching, and improve completion item list sorting Update tm4e upstream, fix issues with symbol matching, and improve completion item list sorting Jan 29, 2024
@Rosemoe Rosemoe merged commit 945f30c into Rosemoe:main Jan 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rosemoe Rosemoe Rosemoe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dingyi222666 @Rosemoe