Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update class.cpp to avoid compiler warnings #283

Closed
wants to merge 1 commit into from
Closed

Update class.cpp to avoid compiler warnings #283

wants to merge 1 commit into from

Conversation

andriish
Copy link
Contributor

Update class.cpp to avoid compiler warnings

source/class.cpp:667:1: warning: multi-line comment [-Wcomment]
  667 | // #define PYBIND11_OVERLOAD_INT(ret_type, cname, name, ...) { \
      | ^

lyskov
lyskov requested changes Feb 14, 2024
View reviewed changes
Copy link
Member

@lyskov lyskov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm.. I want to keep this for reference, - do you think we can around the warning by using range comment /*...*/?

@andriish andriish mentioned this pull request Mar 13, 2024
Merged
@andriish
Copy link
Contributor Author

See #285

@andriish andriish closed this Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyskov lyskov lyskov requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andriish @lyskov