Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add description in Thai (th) #104

Closed
wants to merge 1 commit into from
Closed

Conversation

melvinmcrn
Copy link

@melvinmcrn melvinmcrn commented Oct 28, 2023

@Roshy10 just separated TH into this PR.

Copy link
Owner

@Roshy10 Roshy10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you'll need to add it to /src/i18n.js too for it to be used

@melvinmcrn
Copy link
Author

Please review again. Thanks. @Roshy10

@Roshy10
Copy link
Owner

Roshy10 commented Oct 30, 2023

you seem to have added a selector in the footer, by default the language set in the browser will be used, so I don't think it's necessary to do that. It will also look a bit messy which I'm not keen on

Please also squash your commits

Copy link
Owner

@Roshy10 Roshy10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment above

@melvinmcrn
Copy link
Author

@Roshy10 all done. please review again.

Copy link
Owner

@Roshy10 Roshy10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure to revert the package json and package lock too

@melvinmcrn melvinmcrn closed this May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants