Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It's not obvious that a page navigation happened #72

Closed
Shelob9 opened this issue Apr 2, 2020 · 2 comments · May be fixed by #73
Closed

It's not obvious that a page navigation happened #72

Shelob9 opened this issue Apr 2, 2020 · 2 comments · May be fixed by #73

Comments

@Shelob9
Copy link
Contributor

Shelob9 commented Apr 2, 2020

Bug report

What is the current behavior?

The page refresh is very fast, but it's not obvious it happened as the top of the page does not change.

Solution

In Slack https://rosiesews.slack.com/archives/C010RDJL7AA/p1585845125464700 we discussed putting the page title above the call to action:

For desktop:

desktop

For mobile:
mobile

Also, the blue bar should go away.

https://rosiesews.slack.com/archives/C010RDJL7AA/p1585845379466000
@Shelob9
Copy link
Contributor Author

Shelob9 commented Apr 2, 2020

I have PR #71 open to change headings from h1 to h2s, this will likely replace that PR. But I want to make sure I keep titles as h1s.

Shelob9 added a commit to Shelob9/masksnow that referenced this issue Apr 2, 2020
@Shelob9
RosieSews#72 put the title above call to action
6567c24
Shelob9 added a commit to Shelob9/masksnow that referenced this issue Apr 2, 2020
@Shelob9
RosieSews#72 place page title above heading
5bee894
Shelob9 added a commit to Shelob9/masksnow that referenced this issue Apr 2, 2020
@Shelob9
Remove blue background from CTA RosieSews#72
75951e1
Shelob9 added a commit to Shelob9/masksnow that referenced this issue Apr 2, 2020
@Shelob9
RosieSews#72 remove redundant page title h2s RosieSews#71
d2e9214
@Shelob9 Shelob9 mentioned this issue Apr 2, 2020
Open
Shelob9 added a commit to Shelob9/masksnow that referenced this issue Apr 2, 2020
@Shelob9
change CTA button color RosieSews#72
39b7e8c
@gvan12
Copy link
Contributor

gvan12 commented Apr 5, 2020

closing as this has been addressed in some of the other updates that've been made.

@gvan12 gvan12 closed this as completed Apr 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move page title up and remove blue bar Shelob9/masksnow
2 participants
@Shelob9 @gvan12