Move page title up and remove blue bar #73
Conversation
There was a problem hiding this comment.
Looks good - one logic piece isn't quite working how we want though - to test - run the preview URL's through the twitter card validator located here: https://cards-dev.twitter.com/validator
| //Description may be set, else, use excerpt | ||
| if (postMeta.hasOwnProperty('description')) { | ||
| description = postMeta.description; | ||
| } else if (postNode.hasOwnProperty('excerpt')) { | ||
| description = postNode.excerpt; |
There was a problem hiding this comment.
I think one of these isn't working quite right. If you look at the twitter card validator for the preview site - the only card with a description now is the patterns page. So I think one of those two checks aren't actually working as they are always overwriting the siteDescription.
There was a problem hiding this comment.
I think one of those two checks aren't actually working as they are always overwriting the siteDescription.
If the post has frontmatter.description, it is overwriting siteDescription
|
But the validator card makes it look like there is no description. So the
property likely exists but is a blank string? I can dig more later tonight.
…On Thu, Apr 2, 2020, 6:15 PM Josh Pollock ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/components/SEO.js
<#73 (comment)>:
> + //Description may be set, else, use excerpt
+ if (postMeta.hasOwnProperty('description')) {
+ description = postMeta.description;
+ } else if (postNode.hasOwnProperty('excerpt')) {
+ description = postNode.excerpt;
I think one of those two checks aren't actually working as they are always
overwriting the siteDescription.
If the post has frontmatter.description, *it is* overwriting
siteDescription
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#73 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB2H6HKDN3QPH2ATT24LJM3RKUMBVANCNFSM4L2W5P6A>
.
|
|
I believe the SEO work you've done here is merged into a branch on the repo called If that's the case - I think we can close this one - feel free to pick back up on the seo stuff on that branch - it's a little closer to current state of master than this one is now. |
Fixes #72