Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added .matches(_:ignoring:) #30

Merged
merged 2 commits into from
Oct 25, 2021
Merged

Conversation

KyLeggiero
Copy link
Collaborator

This resolves #29 by allowing two semantic versions to be compared without regarding certain identifiers.

  • Also moved Comparable conformance to a new file; placed new code there
  • Also moved Comparable tests to a new file; placed new tests there

Janitorial work

  • Updated README

    • Noted test-proven SemVer implementation
    • Added examples of subtly-bad semantic versions
    • Added note about Codable conformance
  • Updated header comments

  • Added missing watchOS platform

  • Added SemVerCodableTests to non-Xcode test files

  • Added tests checking subtly-wrong SemVer strings

This allows two semantic versions to be compared without regarding certain identifiers
- Also moved `Comparable` conformance to a new file; placed new code there
- Also moved `Comparable` tests to a new file; placed new tests there
- Updated README 
    - Noted test-proven SemVer implementation
    - Added examples of subtly-bad semantic versions
    - Added note about `Codable` conformance

- Updated header comments
- Added missing watchOS platform
- Added `SemVerCodableTests` to non-Xcode test files
- Added tests checking subtly-wrong SemVer strings
@KyLeggiero KyLeggiero added the enhancement New feature or request label Oct 25, 2021
@KyLeggiero KyLeggiero self-assigned this Oct 25, 2021
@KyLeggiero KyLeggiero linked an issue Oct 25, 2021 that may be closed by this pull request
Copy link
Collaborator Author

@KyLeggiero KyLeggiero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@KyLeggiero KyLeggiero merged commit adcdc08 into develop Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add comparison function which ignores PATCH/MINOR
1 participant