Feature/switch component #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
The GIF preview makes the background look lighter than it is - using |
- Renders either a Switch or a Select based on media query
- Export types correctly
- Also allows us to attach a pseudo element for styling
- Fixes issue with active state border overlap
m7kvqbe1
force-pushed
the
feature/switch-component
branch
from
0f79062
to
100d0ba
Compare
|
I think I'm gonna have to retweak the active state of the switch ever so slightly. Just realised it's re-rendering itself when the text goes bold, meaning it can potentially throw off other components that are situated next to it. Maybe just darkening the text with no bold might be ok visually |
…e SVGs, but the work is complete
- Make APIs match with `Select` for easy interoperability - Remove the need for the adapter (now using Formik enhancer) - Two lines need uncommenting post `Select` merge for responsive
antictor
approved these changes
Sep 19, 2019
The gif is slightly out of date - designer has resolved this with a slight style tweak. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
#194
Overview
Implement and document the responsive Switch component.
Reason
Work carried out
Screenshot
Developer notes
Using the CSS frameworkcolor()helper I seem to be unable to pick the same background.Awaiting<Select />implementation in order to finish adding responsive behaviour @mobile.