Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/privacy policy #410

Merged
merged 2 commits into from Nov 28, 2019
Merged

Feature/privacy policy #410

merged 2 commits into from Nov 28, 2019

Conversation

fdpe5x4q
Copy link
Contributor

@fdpe5x4q fdpe5x4q commented Nov 7, 2019

Ensure the doc site has a privacy policy

#369

Overview

Took the gov.uk privacy policy and added it into the docs site in markdown format. The page is called privacy.md

Reason

The site needs a privacy policy so that users know and can accept/reject how we will use information related to a user's browsing of content on the site. We may also need a separate cookie policy as they do on gov.uk sites.

Work carried out

  • Privacy policy content adjusted to fit standards team needs.
  • Privacy policy content changed into markdown format.
  • Pop-up cookie banner yet to be completed.

Screenshot

Screenshot 2019-11-07 at 14 08 59

Copy link
Collaborator

@thyhjwb6 thyhjwb6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be a single commit and the message should read as an imperative, such as Add privacy policy.

You can achieve this from your branch with:

git reset HEAD~2
git add .
git commit -m "Add privacy policy"

@m7kvqbe1
Copy link
Member

m7kvqbe1 commented Nov 7, 2019

This branch is also rather behind develop (the security audit is failing but the vulnerability has already fixed on the develop branch) so it would be worth rebasing it and then force pushing back up:

git pull origin develop --rebase
git push origin feature/privacy-policy --force

@m7kvqbe1
Copy link
Member

m7kvqbe1 commented Nov 7, 2019

I notice it's showing the privacy policy in the main navigation. To prevent this, we could add some frontmatter to the top of the MDX files we want to exclude from the main navigation:

---
excludeFromNavigation: true
---

# Some MDX content

and then in this file change this line to filter pages based on that frontmatter property: https://github.com/Royal-Navy/standards-toolkit/blob/e4cab1a49b02e378e380ee19136724b0393294a1/packages/docs-site/src/utils/nav.js#L38

You'll also need to update the relevant GraphQL query here:

https://github.com/Royal-Navy/standards-toolkit/blob/e4cab1a49b02e378e380ee19136724b0393294a1/packages/docs-site/src/hooks/useNavigationQuery.js#L12

Feel free to ask us if you have any questions and we can help.

@m7kvqbe1 m7kvqbe1 self-requested a review November 7, 2019 18:00
@fdpe5x4q fdpe5x4q force-pushed the feature/privacy-policy branch 2 times, most recently from 2238908 to 60e1100 Compare November 20, 2019 15:34
Copy link
Member

@m7kvqbe1 m7kvqbe1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This just need another rebase - because we resolved another security issue.

@m7kvqbe1 m7kvqbe1 merged commit 4f401ce into develop Nov 28, 2019
@m7kvqbe1 m7kvqbe1 deleted the feature/privacy-policy branch November 28, 2019 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants