Add scrollable tab set #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thyhjwb6
force-pushed
the
feature/scrollable-tab-set
branch
from
1a9024b
to
bba5c18
Compare
|
Is this WIP? |
thyhjwb6
force-pushed
the
feature/scrollable-tab-set
branch
5 times, most recently
from
baa11b1
to
38eeb06
Compare
m7kvqbe1
approved these changes
Nov 28, 2019
| setActiveTab(index) | ||
|
|
||
| if (onChangeCallback) { | ||
| onChangeCallback(activeTab, title) | ||
| onChangeCallback(index) |
There was a problem hiding this comment.
I know this was already here before and it's annoyingly a breaking change but maybe we could lose the word 'callback' and it could become onChange.
There was a problem hiding this comment.
Maybe there is a task here to carry out ahead of the v2.0.0 release - we could make our interfaces more consistent across the entire library.
| } | ||
| } | ||
|
|
||
| const headerClassNames = classNames('rn-tab-set__head', { | ||
| 'is-scrollable': scrollable, |
There was a problem hiding this comment.
Could we just add this stateful class in once, at the root of the component?
| itemsRef.current = itemsRef.current.slice(0, items.length) | ||
| }, [items]) | ||
|
|
||
| function updateCurrentScrollToTab(change: (currentTab: number) => number) { |
There was a problem hiding this comment.
Lovely bit of inversion of control :)
thyhjwb6
force-pushed
the
feature/scrollable-tab-set
branch
from
70c8ba7
to
b39650e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
#225
Overview
Adding a scrollable tab set component
Reason
When there are a large number of tabs then these need to be scrolled through.
Work carried out
Screenshot
Developer notes
Still to do: