Add smooth scrolling to scrollable tab set #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thyhjwb6
force-pushed
the
feature/smooth-scrolling
branch
6 times, most recently
from
3f18f0f
to
e932cb4
Compare
thyhjwb6
changed the title
m7kvqbe1
approved these changes
Nov 28, 2019
|
|
||
| scrollToSpy = jest | ||
| .spyOn(tabs, 'scrollTo') | ||
| // @ts-ignore |
There was a problem hiding this comment.
What did it get upset about here?
There was a problem hiding this comment.
The destructuring of the scrollTo parameter.
thyhjwb6
force-pushed
the
feature/smooth-scrolling
branch
from
e932cb4
to
916d89c
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
#218
Overview
Make scrolling smooth when browsing tabs in scrollable tab set.
Reason
Without smooth scrolling the user experience is awkward because it feels like the tabs are disappearing.
Work carried out
Screenshot