Generate components from SVGs in doc site #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thyhjwb6
force-pushed
the
feature/docs-site-svgr
branch
2 times, most recently
from
0e8cc01
to
38c7944
Compare
thyhjwb6
force-pushed
the
feature/docs-site-svgr
branch
4 times, most recently
from
38c7944
to
d5b03a4
Compare
In favour of SVGR to automate optimisation of SVGs
thyhjwb6
force-pushed
the
feature/docs-site-svgr
branch
from
d348cb0
to
a6cf565
Compare
thyhjwb6
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
#437
Overview
Replaced the loading of inline SVGs with a build process which converts SVGs to React components to be added to the documentation.
Reason
There is a dependency on
gatsby-plugin-react-svgwhich has upstream issues with outputting SVGs that contains elements with the same ID. This leads to the document being badly structure and therefore issues with presenting SVGs.There is the added benefit that this automates the manual task which is optimising SVGs.
Work carried out
gatsby-plugin-react-svgdependencyScreenshot
Developer notes
Special attention should be given to the styles which have been moved to
masthead.scss. This is because themastheadis dependent onsite-logo.svgwhich had embedded styles and SVGR could not convert it to a component without errors.