remove keras_templates imports from models __init__ #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbuergers
added
the
Type: Improvement
mi2354
reviewed
Dec 22, 2023
| @@ -94,7 +94,7 @@ def _index_has_constant_increase(df: pd.DataFrame): | |||
| else: | |||
| return False | |||
|
|
|||
| if type(df.index) == pd.core.indexes.datetimes.DatetimeIndex and ( | |||
| if type(df.index) is pd.core.indexes.datetimes.DatetimeIndex and ( | |||
There was a problem hiding this comment.
isinstance(df.index, pd.core.indexes.datetimes.DatetimeIndex)
There was a problem hiding this comment.
Ruben preferred the type() is syntax. I don't mind either way. I think the situations in which they differ almost never occur, and should not in this case, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#83
in
modelsandmetricswe imported keras functions fromkeras_templatesin the__init__.py, so even if users ofSAMwant to not use keras they need to have this rather big dependency installed if they want to use, say, a Lasso model.This PR needs some more work and most of all testing so that the parts of SAM that should not depend on KERAS or TENSORFLOW have all tests passing without it being installed.