Bug fix. #10
Closed
Bug fix. #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
其他几处signed_extend的实现也看起来不太对，可能需要都改成用我这个实现？ |
|
感谢, 那里确实没考虑sign-extended的情况, 不过有效位未必是21, 还可能是16, 简单修了: 其它地方的好像没问题?未验证 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
指令恢复时对如0x54ff6b28 b.hi -0x129d 指令做重定向的offset的计算是错误的。
是由于offset imm19是一个signed值，但代码中__fix_cond_comp_test_branch计算absolute_addr将其视为unsigned导致的。