remove dependency on Test::TempDir #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unless you know special sauce to get the File::NFSLock author to speedily release my pull request to it, please accept this one from ether to your module. It is an absolute pain to talk to win32 authors and have to tell them "yeah, some guys just don't give a shit about making their stuff run everywhere". |
|
Test::TempDir::Tiny now exists as a much safer alternative. |
karenetheridge
force-pushed
the
topic/fix_tempdirs
branch
from
14370aa
to
9489ad0
Compare
|
I fixed the PR to use Test::TempDir::Tiny, which adds a bit of extra gravy on top of Path::Tiny->tempdir (and also the features that were nice in Test::TempDir). Please apply this soon! TTD is terrifying to have in a codebase, as well as mswin32-hostile. |
|
bump |
rsrchboy
added a commit
that referenced
this pull request
Feb 24, 2015
remove dependency on Test::TempDir
rsrchboy
added a commit
that referenced
this pull request
Feb 24, 2015
|
\o/ Thanks. :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
..it has issues on MSWin32 (File::NFSLock is busted), and does not properly
handle parallelism as advertised (File::NFSLock again)