Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync once files received #4

Closed
wants to merge 1 commit into from
Closed

Sync once files received #4

wants to merge 1 commit into from

Conversation

benrubson
Copy link
Contributor

Hi,

Here is a PR which simply sync() once files received, for data consistency.

Many thanks 馃憤

Initial report there, pushed here by convenience.

@WayneD
Copy link
Member

WayneD commented Jun 8, 2020

I don't like the idea of forcing all pending data from anyone's disk activity to disk just because someone ran an rsync. For a remote daemon someone could put a sync into the "post-xfer exec" script. For a receiver via ssh, I'd suggest creating a shell script and running it via --rsync-path=rsync-and-sync when you want the syncing to be done.

#!/bin/bash
# maybe check if we're the --sender and avoid the sync?
# maybe save rsync's ret value & always do the sync & then return the ret value?
rsync "${@}" && sync

@WayneD WayneD closed this Jun 8, 2020
@benrubson
Copy link
Contributor Author

OK Wayne, thank you for your feedback.
I liked the idea that, as a backup program, rsync replied with "OK : backup successfully finished, and your data is safely on disk".
I'll use a workaround then :)
Thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants