bugfix: initializing allocated memory for ISR functions #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allocating dynamic memory for ISR functions using
malloc()
leaves that memory uninitialized. This causes latter code to perform conditional jumps on uninitialized values. This causes that a GPIO can be randomly marked as already used (which happens in my case).Output produced while debugging with
valgrind
:The code that does the conditional jump on an uninitialized value:
The proposed solution simply uses
calloc()
instead ofmalloc()
. This causes all the allocated memory to be initialized to 0.