Added autocomplete for \documentclass. #731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HannahSchellekens
added
the
enhancement
HannahSchellekens
changed the title
|
On my side this PR definitely breaks something, i.e. when I check out PR #726 the refactored code works fine, but when I check this out then I get many errors, and the 'Project' view is broken. |
|
Sorry to ping you @stenwessel :) |
|
@RubenSchellekens I still have the same errors, which are now also in master. Are you sure it's working for you? I tested on three different Windows systems (2x7 and 8.1) and all three had the same problems. |
|
Yup. Works fine for me. |
PHPirates
reviewed
Nov 7, 2018
| * Copyright (c) 2018 Ruben Schellekens | ||
| */ | ||
| public static final Icon DOT_CLASS = IconLoader.getIcon( | ||
| "/nl/rubensten/texifyidea/icons/dot-cls.png" |
There was a problem hiding this comment.
@RubenSchellekens Did you push this file? I can't find it anywhere, and especially not in the place it should be. It may be the reason why the plugin is broken for me (actually it's broken on any system but yours).
|
Indeed... Forgot to add the icon to git. Just did it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #725. Branched from
refactor-texifyutil(see PR #726).Additions
article,IEEEtran,proc,report,book,slides,memoir,letter,beamer.\ProvideClassin the source folders (not in the whole project). So you can have amycls.clsin your (re)source folders with\ProvideClass{mycls}and it will show up in the autocomplete.Fixes
IndexCommandsUtilBasemodifying the input commands incorrectly: the\prefix check was accidentally reversed.Screenshots