Support LDflex expressions resulting in unthenable.

[satotake]

Kind of change

• Bugfix
• Feature
• Code style update
• Refactor
• Build-related changes
• Other, please describe:

Proposed changes

This fixation can actually eliminate error described in #12 but I doubt if its result is what you expect.

Relevant issues

#12

Breaking change?

• Yes
• No

Requirements check

• All tests are passing
• New/updated tests are included

Additional info

This fixation can actually eliminate the above error but I doubt if its result is what you expect.

For example,

<Value src="[https://ruben.verborgh.org/profile/#me]"/>

Rendered as

"https://ruben.verborgh.org/profile/#me"

Any comments and suggestion will be appreciated.

[coveralls]

Pull Request Test Coverage Report for Build 132

• 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 100.0%

---

Totals
Change from base Build 130:	0.0%
Covered Lines:	272
Relevant Lines:	272

---

💛 - Coveralls

[RubenVerborgh]

Thanks!

I'm thinking that we should be open to any kind of objects, since there is no hard test to check whether an object is an LDflex expression. So perhaps, if an object is not thenable, we should just return the object itself.

[satotake]

Helpful response. Thanks!

In that case, all we need is to just remove resolveExpression in ExpressionEvaluator.

Then, above jsx-expressions are converted into below elements.

<p> <Value src="[https://ruben.verborgh.org/profile/#me]"/> </p>
<p> <Value src="[https://this.is.invalid/#expression"/> </p>
<p> <Value src={1234} /> </p>

<p> https://ruben.verborgh.org/profile/#me </p>
<p> <span class="solid value error" data-error="Expression &quot;[https://this.is.invalid/#expression &quot; is invalid: Unexpected token :"></span> </p>
<p> 1234 </p>

In addition, some tests are fixed.

Sorry that I failed to use PR template. so I updated my top comment.

[satotake]

After all, instead removing resolveExpression itself, I removed error check in resolveExpression.

[RubenVerborgh]

Apologies for the extreme delay, and thanks again for your contribution.