Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Feature: disable tool swap on attack #370

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

NathanMarsee
Copy link

Added a new config option to disable swapping to a tool when attacking an entity.
Feedback is appreciated - this is my first time editing a Forge mod like this.
(By the way, I am @Apollonir on discord)

new config option to disable swapping to a tool when attacking an entity
@RubixDev
Copy link
Owner

I'll need to have a proper look at the code changes when I get back to all this (ik it's not a lot, but still). In the meantime: I'm not super satisfied with the name "DisableAttackSwap" for the option. I guess it's ok, but if you've got any other ideas, I'd be happy to hear them.

And how did you get the translations? Can you actually speak all four languages, or did you just use some automatic translation tool? I'd always much prefer proper translations from people who actually speak the language. For example, before I took over, the German translations were pretty obviously machine generated and a pain to read.

@RubixDev RubixDev added enhancement New feature or request priority: high High priority labels Jul 14, 2024
@NathanMarsee
Copy link
Author

I agree — "DisableAttackSwap" was just the best I could come up with, but I'm sure a better name could be chosen. My other ideas were DIsableCombatSwap, NoCombat, NoSwordSwap, DisableSword, and BreakingOnly, but I don't especially like any of these either. It's up to you in the end.

And second, yes the translations are machine-generated — I only know English and a little Spanish. I should have marked them as placeholders until we could finalize the English description and then get some real translations done, I can do that today if you'd like.

Lastly, I've since noticed a few small annoyances in my testing (though the feature does technically do what it says without issue). Namely accidentally hitting a block during combat will swap to the relevant tool and then not swap back so long as you keep attacking. That's another part of the code I should look into and see if I can get to a more intuitive state while this feature is enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority: high High priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants